From patchwork Sat Aug 17 21:51:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mischa POSLAWSKY X-Patchwork-Id: 11099317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B5E9214DB for ; Sat, 17 Aug 2019 21:51:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99F9A2842D for ; Sat, 17 Aug 2019 21:51:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 87CE028862; Sat, 17 Aug 2019 21:51:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5AF02842D for ; Sat, 17 Aug 2019 21:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbfHQVvK (ORCPT ); Sat, 17 Aug 2019 17:51:10 -0400 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:34133 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbfHQVvK (ORCPT ); Sat, 17 Aug 2019 17:51:10 -0400 Received: from xeops.shiar.net ([83.161.198.138]) by smtp-cloud9.xs4all.net with ESMTP id z6bLh9HtCzaKOz6bMhoPMV; Sat, 17 Aug 2019 23:51:08 +0200 Received: by xeops.shiar.net (Postfix, from userid 1000) id 64E4A6E649E; Sat, 17 Aug 2019 23:51:07 +0200 (CEST) From: Mischa POSLAWSKY To: git@vger.kernel.org, =?utf-8?b?0J7Qu9GPINCi0LXQu9C10LbQvdCw0Y8=?= Cc: Junio C Hamano Subject: [PATCH] ref-filter: initialize empty name or email fields Date: Sat, 17 Aug 2019 23:51:07 +0200 Message-Id: <20190817215107.13733-1-git@shiar.nl> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-CMAE-Envelope: MS4wfOsj5bC0mvljmMnYntuSzfj7+Gk0HNiiXYnS10kNMcce1AKHfwGqFowHmEVrTg5C/LfnBHkg2XSTNGrRx1k8f3yFxAsm4kU2zk6ysFsU8OFTi8THOG2a 3rjDpHpeI2v4iS4e6xbElvis2RZVyD/xbWnrHWepGWhqXgR4W26JpfgHcxBcx8lpLOKlwBc4gtEzQes3/L0Ei+fQ+BGgQpOkgjY8ZUeDwGAjfD7HEKps3JPT pvrazmC2c/VEPvxgKc+nbyG1OZ2GgFdzbCr2/VG+q4k= Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Formatting $(taggername) on headerless tags such as v0.99 in Git causes a SIGABRT with error "munmap_chunk(): invalid pointer", because of an oversight in commit f0062d3b74 (ref-filter: free item->value and item->value->s, 2018-10-19). Signed-off-by: Mischa POSLAWSKY --- If I understand correctly, such tags cannot be produced normally anymore. Therefore I'm unsure how to make tests, and if that is even warranted. ref-filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index f27cfc8c3e..7338cfc671 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1028,7 +1028,7 @@ static const char *copy_name(const char *buf) if (!strncmp(cp, " <", 2)) return xmemdupz(buf, cp - buf); } - return ""; + return xstrdup(""); } static const char *copy_email(const char *buf) @@ -1036,10 +1036,10 @@ static const char *copy_email(const char *buf) const char *email = strchr(buf, '<'); const char *eoemail; if (!email) - return ""; + return xstrdup(""); eoemail = strchr(email, '>'); if (!eoemail) - return ""; + return xstrdup(""); return xmemdupz(email, eoemail + 1 - email); }