From patchwork Mon Dec 9 18:25:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Beat Bolli X-Patchwork-Id: 11279969 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7DC7F6C1 for ; Mon, 9 Dec 2019 18:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D9BA20836 for ; Mon, 9 Dec 2019 18:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726532AbfLISfm (ORCPT ); Mon, 9 Dec 2019 13:35:42 -0500 Received: from mail-gateway-shared12.cyon.net ([194.126.200.65]:49620 "EHLO mail-gateway-shared12.cyon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbfLISfm (ORCPT ); Mon, 9 Dec 2019 13:35:42 -0500 Received: from s019.cyon.net ([149.126.4.28]) by mail-gateway-shared12.cyon.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim) (envelope-from ) id 1ieNjL-0005Iw-WE for git@vger.kernel.org; Mon, 09 Dec 2019 19:26:02 +0100 Received: from [10.20.10.233] (port=20388 helo=mail.cyon.ch) by s019.cyon.net with esmtpa (Exim 4.92) (envelope-from ) id 1ieNjK-0025mH-O2; Mon, 09 Dec 2019 19:25:58 +0100 Received: by drbeat.li (Postfix, from userid 1000) id 84187180083; Mon, 9 Dec 2019 19:25:58 +0100 (CET) From: Beat Bolli To: git@vger.kernel.org Cc: Paul Mackerras , Beat Bolli Subject: [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary Date: Mon, 9 Dec 2019 19:25:33 +0100 Message-Id: <20191209182534.309884-1-dev+git@drbeat.li> X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - s019.cyon.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - drbeat.li X-Get-Message-Sender-Via: s019.cyon.net: authenticated_id: ig@drbeat.li X-Authenticated-Sender: s019.cyon.net: ig@drbeat.li X-Source: X-Source-Args: X-Source-Dir: X-OutGoing-Spam-Status: No, score=-1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Git learned the "reference" pretty format in 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19). Use it also in gitk instead of duplicating the format string. This way, gitk always follows the formatting convention defined by git. Signed-off-by: Beat Bolli --- Junio, this goes on top of dl/pretty-reference, currently in pu. Thanks! gitk-git/gitk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index a14d7a16b2..cc89fb25d2 100755 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -9392,8 +9392,7 @@ proc mktaggo {} { proc copysummary {} { global rowmenuid autosellen - set format "%h (\"%s\", %ad)" - set cmd [list git show -s --pretty=format:$format --date=short] + set cmd [list git show -s --pretty=reference] if {$autosellen < 40} { lappend cmd --abbrev=$autosellen }