diff mbox series

[2/3] doc: remove non pure ASCII characters

Message ID 20191212204655.10425-2-jn.avila@free.fr (mailing list archive)
State New, archived
Headers show
Series [1/3] doc: reword -B option of diff into something sensible | expand

Commit Message

Jean-Noël Avila Dec. 12, 2019, 8:46 p.m. UTC
Non ASCII characters may be handled by publishing chains, but right
now, nothing indicates the encoding of files. Moreover, non ASCII
source strings upset the localization toolchain.

Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
---
 Documentation/git-clone.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Junio C Hamano Dec. 13, 2019, 7:53 p.m. UTC | #1
Jean-Noël Avila <jn.avila@free.fr> writes:

> Non ASCII characters may be handled by publishing chains, but right
> now, nothing indicates the encoding of files. Moreover, non ASCII
> source strings upset the localization toolchain.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
>  Documentation/git-clone.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks.  I've always wanted to do this, but it is a bit surprising
that there is only this single instance?

> diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
> index 34011c2940..2e8babe671 100644
> --- a/Documentation/git-clone.txt
> +++ b/Documentation/git-clone.txt
> @@ -262,9 +262,9 @@ or `--mirror` is given)
>  	All submodules which are cloned will be shallow with a depth of 1.
>  
>  --[no-]remote-submodules::
> -	All submodules which are cloned will use the status of the submodule’s
> +	All submodules which are cloned will use the status of the submodule's
>  	remote-tracking branch to update the submodule, rather than the
> -	superproject’s recorded SHA-1. Equivalent to passing `--remote` to
> +	superproject's recorded SHA-1. Equivalent to passing `--remote` to
>  	`git submodule update`.
>  
>  --separate-git-dir=<git dir>::
Jean-Noël Avila Dec. 13, 2019, 9:37 p.m. UTC | #2
On Friday, 13 December 2019 20:53:31 CET Junio C Hamano wrote:
> Jean-Noël Avila <jn.avila@free.fr> writes:
> 
> > Non ASCII characters may be handled by publishing chains, but right
> > now, nothing indicates the encoding of files. Moreover, non ASCII
> > source strings upset the localization toolchain.
> >
> > Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> > ---
> >  Documentation/git-clone.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Thanks.  I've always wanted to do this, but it is a bit surprising
> that there is only this single instance?

There's another one in git-format-patch.txt, "Uwe Kleine-König diet", but this one does not seem to cause issues and it is difficult to replace it with ASCII only.

Should I try to find an alternative text?

> 
> > diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
> > index 34011c2940..2e8babe671 100644
> > --- a/Documentation/git-clone.txt
> > +++ b/Documentation/git-clone.txt
> > @@ -262,9 +262,9 @@ or `--mirror` is given)
> >  	All submodules which are cloned will be shallow with a depth of 1.
> >  
> >  --[no-]remote-submodules::
> > -	All submodules which are cloned will use the status of the submodule’s
> > +	All submodules which are cloned will use the status of the submodule's
> >  	remote-tracking branch to update the submodule, rather than the
> > -	superproject’s recorded SHA-1. Equivalent to passing `--remote` to
> > +	superproject's recorded SHA-1. Equivalent to passing `--remote` to
> >  	`git submodule update`.
> >  
> >  --separate-git-dir=<git dir>::
>
Junio C Hamano Dec. 13, 2019, 9:58 p.m. UTC | #3
Jean-Noël AVILA <jn.avila@free.fr> writes:

>> Thanks.  I've always wanted to do this, but it is a bit surprising
>> that there is only this single instance?
>
> There's another one in git-format-patch.txt, "Uwe Kleine-König diet", but this one does not seem to cause issues and it is difficult to replace it with ASCII only.
>
> Should I try to find an alternative text?

No, let's keep names of people as-is, if they are not causing
issues.

What surprised me was the apparent lack of these "smarter"
apostrophes and quotes.

Thanks.

>
>> 
>> > diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
>> > index 34011c2940..2e8babe671 100644
>> > --- a/Documentation/git-clone.txt
>> > +++ b/Documentation/git-clone.txt
>> > @@ -262,9 +262,9 @@ or `--mirror` is given)
>> >  	All submodules which are cloned will be shallow with a depth of 1.
>> >  
>> >  --[no-]remote-submodules::
>> > -	All submodules which are cloned will use the status of the submodule’s
>> > +	All submodules which are cloned will use the status of the submodule's
>> >  	remote-tracking branch to update the submodule, rather than the
>> > -	superproject’s recorded SHA-1. Equivalent to passing `--remote` to
>> > +	superproject's recorded SHA-1. Equivalent to passing `--remote` to
>> >  	`git submodule update`.
>> >  
>> >  --separate-git-dir=<git dir>::
>>
diff mbox series

Patch

diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
index 34011c2940..2e8babe671 100644
--- a/Documentation/git-clone.txt
+++ b/Documentation/git-clone.txt
@@ -262,9 +262,9 @@  or `--mirror` is given)
 	All submodules which are cloned will be shallow with a depth of 1.
 
 --[no-]remote-submodules::
-	All submodules which are cloned will use the status of the submodule’s
+	All submodules which are cloned will use the status of the submodule's
 	remote-tracking branch to update the submodule, rather than the
-	superproject’s recorded SHA-1. Equivalent to passing `--remote` to
+	superproject's recorded SHA-1. Equivalent to passing `--remote` to
 	`git submodule update`.
 
 --separate-git-dir=<git dir>::