From patchwork Fri Jan 24 03:34:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emily Shaffer X-Patchwork-Id: 11349593 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 14CB7921 for ; Fri, 24 Jan 2020 03:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E346124125 for ; Fri, 24 Jan 2020 03:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Z8/qpD0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729898AbgAXDfb (ORCPT ); Thu, 23 Jan 2020 22:35:31 -0500 Received: from mail-yw1-f74.google.com ([209.85.161.74]:33646 "EHLO mail-yw1-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729880AbgAXDfa (ORCPT ); Thu, 23 Jan 2020 22:35:30 -0500 Received: by mail-yw1-f74.google.com with SMTP id e66so539802ywf.0 for ; Thu, 23 Jan 2020 19:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=cyO149RfctL+SLMlcgnvh4ZsUVUgUM/UYJB6OSgVkmo=; b=Z8/qpD0J8GUwjdDZuii7wni8NTGy94wH/4XLLMtiN40WE5s8nAOvO2WcheJhYDilYj hXQCU+O69qgunO0/MCyUA+jxUgJ2Gytxfb5ZK8cWS7AoLDrkjwNFh4h+EGxpBKQTzDtV wzWOmcuV1m0S91pq2D/Avy94IQcgJPLjY7/+xwOjtZvLAeFHWM6XYfktsPrkfrhf3mV5 POJ/1NwvvcMjQTGf0klLixnxRuCpT35cYo0Tn3DOoL81v6SHH15SBzEC3rIbyrRUxx1h RUF2fHGWUapixDO3/RVK7WkGpuVZdfObrl2GRIxRSVs6NJD1LXnF77C8IYuorSv8KYW4 3Ncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=cyO149RfctL+SLMlcgnvh4ZsUVUgUM/UYJB6OSgVkmo=; b=OgnzlfgB8DLuKiYeT8loI/7NIlD5j23gxLpcQpW0M6TaXwm51oGGoSi0XfUOS8XYAo 3Zs84gfB+It70GYRxj1YD8Q+5R7AlLdHqE6uHUzEWurCRsCmYV/zvkf5CaGXjn9gn2iw C09bQI1AfdiIWKL9LJa9/qM8oybQa8UM/5JBcg8ERGT0JpIdplFtGMqMkELd5tZz9/s5 6opxLOt7PVueipbfkuFUZDHL1qN3XN1J/Jud5MudbKYTC9KQbo3cYeQksDnTCKo84Ndk ohjTXSnBtAYrA77i4mnCKybQc2kbCt/z22lv6RzC33Jobf37DMjqVJFxhpm8A9/cnfvt rE7Q== X-Gm-Message-State: APjAAAWqVdemYkSif06/EWDVH6dplNZUvds5i+QgE3YKoHkOETnkWaX9 D3yvCmDjFtcyvEXU+aT/5lqMzKdSTFXu+bV6AK+vAkC91nbknbUvtfbn02heaMjY41GMjHJYGlZ 1tqaHePH79IIeY4xhxE/gL5mfGrcY5gfxL42Kp++25Qi42VuHo1heNe/QcAIFreEx278FfSNlpg == X-Google-Smtp-Source: APXvYqzJ73HMj1XWuQYlV5bVAOd1wjPNKqNSVQK2X6FLsNlzanIpaWg07OASuFC8yVoMCMIf/UvjQ+SPpSMW+g2NTkc= X-Received: by 2002:a0d:c6c1:: with SMTP id i184mr616553ywd.389.1579836929284; Thu, 23 Jan 2020 19:35:29 -0800 (PST) Date: Thu, 23 Jan 2020 19:34:29 -0800 In-Reply-To: <20200124033436.81097-1-emilyshaffer@google.com> Message-Id: <20200124033436.81097-9-emilyshaffer@google.com> Mime-Version: 1.0 References: <20200124033436.81097-1-emilyshaffer@google.com> X-Mailer: git-send-email 2.25.0.341.g760bfbb309-goog Subject: [PATCH v5 08/15] bugreport: include user interactive shell From: emilyshaffer@google.com To: git@vger.kernel.org Cc: Emily Shaffer Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Emily Shaffer It's possible a user may complain about the way that Git interacts with their interactive shell, e.g. autocompletion or shell prompt. In that case, it's useful for us to know which shell they're using interactively. Signed-off-by: Emily Shaffer --- bugreport.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bugreport.c b/bugreport.c index 73f6d39517..07b84b9c94 100644 --- a/bugreport.c +++ b/bugreport.c @@ -22,6 +22,7 @@ static void get_system_info(struct strbuf *sys_info) { struct strbuf version_info = STRBUF_INIT; struct utsname uname_info; + char *shell = NULL; /* get git version from native cmd */ strbuf_addstr(sys_info, "git version:\n"); @@ -44,6 +45,10 @@ static void get_system_info(struct strbuf *sys_info) get_compiler_info(sys_info); strbuf_complete_line(sys_info); + shell = getenv("SHELL"); + strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n", + shell ? shell : "(NULL)"); + strbuf_addstr(sys_info, "git-remote-https --build-info:\n"); get_curl_version_info(sys_info); strbuf_complete_line(sys_info);