From patchwork Mon Feb 17 14:44:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew DeVault X-Patchwork-Id: 11386567 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 104D617F0 for ; Mon, 17 Feb 2020 14:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC41920801 for ; Mon, 17 Feb 2020 14:52:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=cmpwn.com header.i=@cmpwn.com header.b="V07/mCOq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729271AbgBQOwq (ORCPT ); Mon, 17 Feb 2020 09:52:46 -0500 Received: from mail.cmpwn.com ([45.56.77.53]:56536 "EHLO mail.cmpwn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728845AbgBQOwp (ORCPT ); Mon, 17 Feb 2020 09:52:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cmpwn.com; s=cmpwn; t=1581950679; bh=LCsoJMxvg5kY0wDDYrHHOd/feJFEMbhLj3YkB0VIvJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=V07/mCOqoKPJU7VKtc+9FgNdKdkiK3MUe1oOZeNdQe/y/rtE9TUvolrMMedf1Q3yZ 4OU23Jq4iOQD9hwSZj0fnJz9Yp2aWLj21dgm86wQscQsTLCEy1fTzlyeBtTyEFsjAa wW5oSwmvYWu7rm7oVBX+5FoWCKqmKJicQZSa09Qc= From: Drew DeVault To: git@vger.kernel.org, Stefan Beller , Junio C Hamano Cc: Drew DeVault Subject: [PATCH 2/2] send-pack: downgrade push options error to warning Date: Mon, 17 Feb 2020 09:44:32 -0500 Message-Id: <20200217144432.43920-2-sir@cmpwn.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200217144432.43920-1-sir@cmpwn.com> References: <20200217144432.43920-1-sir@cmpwn.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Because the receiving end has to explicitly enable receive.advertisePushOptions, and many servers don't, it doesn't make sense to set push options globally when half of your pushes are just going to die. Signed-off-by: Drew DeVault --- send-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/send-pack.c b/send-pack.c index 0407841ae8..8c81825e7d 100644 --- a/send-pack.c +++ b/send-pack.c @@ -439,7 +439,7 @@ int send_pack(struct send_pack_args *args, use_atomic = atomic_supported && args->atomic; if (args->push_options && !push_options_supported) - die(_("the receiving end does not support push options")); + warning(_("the receiving end does not support push options")); use_push_options = push_options_supported && args->push_options;