From patchwork Mon Jul 13 02:48:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "brian m. carlson" X-Patchwork-Id: 11658579 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B126513B1 for ; Mon, 13 Jul 2020 02:49:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97DB4206D9 for ; Mon, 13 Jul 2020 02:49:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (3072-bit key) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b="pSuLOnZf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbgGMCt6 (ORCPT ); Sun, 12 Jul 2020 22:49:58 -0400 Received: from injection.crustytoothpaste.net ([192.241.140.119]:40792 "EHLO injection.crustytoothpaste.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728686AbgGMCtz (ORCPT ); Sun, 12 Jul 2020 22:49:55 -0400 Received: from camp.crustytoothpaste.net (unknown [IPv6:2001:470:b978:101:b610:a2f0:36c1:12e3]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by injection.crustytoothpaste.net (Postfix) with ESMTPSA id 5E30F607F6; Mon, 13 Jul 2020 02:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1594608564; bh=xt7+S0YGkL78M65P52Ea3illT0Bx0Eyn9uNik2bjA/k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Reply-To: Subject:Date:To:CC:Resent-Date:Resent-From:Resent-To:Resent-Cc: In-Reply-To:References:Content-Type:Content-Disposition; b=pSuLOnZf+WKic6ToR+Fa5vdopSL7gVbrYHxueljfuAcTkhbWQgoSucHTFKzbunhN5 xXzxbg89OsSgnwSnBcqELnz1K0JLDJ5PaJnC6sR5xjdmfyTqBBfGEOD0SD3O+qJ0+P F47yrhYEe2RdCt8ixDz7j4Y032+dgMXZ3/xOETdjJy64h5QKF5s9YcJLf5QtahlQEG 2e2TRifS3BKkio6bqHSEa/sldcOk4Bjgtpd5XS8SZA/5Dp7d5/ilnzbvJfY30j/I+G m1eFMMGqY/hgjAegmqdTrXLlwJHXJVrQVMh6B/qIrcqH/Zgj/Hu4Qom6J/SGh5Vn/S DFPGxdlKpJoU9KYsy23EcLvR9bHb2aZgV/iPCi1kMZ/H0sJ3Hkvs2yu7E0ADTo9T3d yXlkRvikA8cIaP7T63n7/9Gw/JJhV7vmbchUPus11MOPk6GgP5I4M1Qj/aAJuun1vZ eSHhUkcCDzAjP4jBTlLKYdZKCyi4s6YIRPHzVDMIIBGFRNsWFAy From: "brian m. carlson" To: Cc: Denton Liu , Derrick Stolee Subject: [PATCH v2 04/39] t3404: prepare 'short SHA-1 collision' tests for SHA-256 Date: Mon, 13 Jul 2020 02:48:34 +0000 Message-Id: <20200713024909.3714837-5-sandals@crustytoothpaste.net> X-Mailer: git-send-email 2.27.0.353.gb9a2d1a020 In-Reply-To: <20200713024909.3714837-1-sandals@crustytoothpaste.net> References: <20200713024909.3714837-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Johannes Schindelin The idea of the magic value "ac4f2ee" in this test is to make the reworded commit `collide2` have the same shortened ID as the commit `collide3`. To port the same idea to the SHA-256 version of Git, we therefore need another magic value that causes the same collision, but this time with the SHA-256 version of the commit IDs. In this patch, we add code guarded by `GIT_TEST_FIND_COLLIDER` to do exactly that. Essentially, a large number of integers is appended to the commit message "collide2" to find such a collision. To make it easier to find such a collision, we reduce the number of digits to 4. The `t/oid-info/oid` file now lists the values found in that way, and the test cases are modified to use those values. As the tests are no longer dependent on SHA-1, we also rename their titles to talk about "commit IDs" instead of "SHA-1s". Signed-off-by: Johannes Schindelin Signed-off-by: brian m. carlson --- t/t3404-rebase-interactive.sh | 50 ++++++++++++++++++++++++++++------- 1 file changed, 41 insertions(+), 9 deletions(-) diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh index 4a7d21f898..2fb2c581cb 100755 --- a/t/t3404-rebase-interactive.sh +++ b/t/t3404-rebase-interactive.sh @@ -30,6 +30,7 @@ Initial setup: . "$TEST_DIRECTORY"/lib-rebase.sh test_expect_success 'setup' ' + test_oid_init && test_commit A file1 && test_commit B file1 && test_commit C file2 && @@ -1250,7 +1251,7 @@ test_expect_success 'rebase -i error on commits with \ in message' ' test_expect_code 1 grep " emp" error ' -test_expect_success SHA1 'short SHA-1 setup' ' +test_expect_success 'short commit ID setup' ' test_when_finished "git checkout master" && git checkout --orphan collide && git rm -rf . && @@ -1262,23 +1263,54 @@ test_expect_success SHA1 'short SHA-1 setup' ' ) ' -test_expect_success SHA1 'short SHA-1 collide' ' +if test -n "$GIT_TEST_FIND_COLLIDER" +then + author="$(unset test_tick; test_tick; git var GIT_AUTHOR_IDENT)" + committer="$(unset test_tick; test_tick; git var GIT_COMMITTER_IDENT)" + blob="$(git rev-parse collide2:collide)" + from="$(git rev-parse collide1^0)" + repl="commit refs/heads/collider-&\\n" + repl="${repl}author $author\\ncommitter $committer\\n" + repl="${repl}data <script && + git fast-import