From patchwork Tue Jul 28 23:34:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "brian m. carlson" X-Patchwork-Id: 11690079 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EBF2414DD for ; Tue, 28 Jul 2020 23:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D576820829 for ; Tue, 28 Jul 2020 23:35:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (3072-bit key) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b="PDZl65GA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbgG1XfO (ORCPT ); Tue, 28 Jul 2020 19:35:14 -0400 Received: from injection.crustytoothpaste.net ([192.241.140.119]:40862 "EHLO injection.crustytoothpaste.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730193AbgG1XfH (ORCPT ); Tue, 28 Jul 2020 19:35:07 -0400 Received: from camp.crustytoothpaste.net (unknown [IPv6:2001:470:b978:101:b610:a2f0:36c1:12e3]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by injection.crustytoothpaste.net (Postfix) with ESMTPSA id DC13A6101D; Tue, 28 Jul 2020 23:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1595979306; bh=UaAP0hIH8vxcehmCkzB++tkC53e5f9DbrGFPfaFhQj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Reply-To: Subject:Date:To:CC:Resent-Date:Resent-From:Resent-To:Resent-Cc: In-Reply-To:References:Content-Type:Content-Disposition; b=PDZl65GA9uFAi9RWgVziWz8/G8wZ1JkO4GxZGQVt9ZhnyzBfsp84De9Gwiqldm40q vWHnAaquu9e+Wwo+eLPadpgmXvZKG/L7KKHvMJFdIcchiR9t7heLlI6Lz4ZrCI3UHf dlm9GykuOafx/+uSWWJGBpNXc/3oyWBglQ852pSXLgOKRb2PzgChhylmtbwLyj3Wzc Gj3T9qku+nZC7JF0TVt++5aLz2c8OT/o4TDHAvRykuuhjEcGZ9DxaHunIR/MtEnWsB sN3GLf2lqchpq0ROlbqshrjVfxXRulmMo856Bqi/cg1fpm/GTJ1IZycxCMKZ1D4T/E gFVw8bEOUo92ga4Loonx8fa1mLePneOTpux1HHT8IpeKl5H5E7bXMgl4x8qccoGJuQ u73FLZdZvq5UQt6c1YAumuDMrK8fYoo5X/wgbf04+k4PTBHZwQ8OvNxFUNRPPKnrWO 5cigsjgvVe5fPhzbCszO/HOZpIWiCgo0UoMhKEg/w672/K9jxvQ From: "brian m. carlson" To: Cc: Eric Sunshine Subject: [PATCH v5 24/39] t9350: make hash size independent Date: Tue, 28 Jul 2020 23:34:31 +0000 Message-Id: <20200728233446.3066485-25-sandals@crustytoothpaste.net> X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6 In-Reply-To: <20200728233446.3066485-1-sandals@crustytoothpaste.net> References: <20200728233446.3066485-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org This test checks for several commit object sizes to verify that objects are encoded as expected. However, the size of a commit object differs between SHA-1 and SHA-256, since each contains a hex representation of the tree's object ID. Since these are root commits, compute the size of each commit by using a constant plus the size of a single hex object ID. In addition, use $ZERO_OID instead of a hard-coded object ID. Signed-off-by: brian m. carlson --- t/t9350-fast-export.sh | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh index 690c90fb82..ba79db6a17 100755 --- a/t/t9350-fast-export.sh +++ b/t/t9350-fast-export.sh @@ -7,6 +7,7 @@ test_description='git fast-export' . ./test-lib.sh test_expect_success 'setup' ' + test_oid_init && echo break it > file0 && git add file0 && @@ -132,12 +133,12 @@ test_expect_success 'reencoding iso-8859-7' ' sed "s/wer/i18n/" iso-8859-7.fi | (cd new && git fast-import && - # The commit object, if not re-encoded, would be 240 bytes. + # The commit object, if not re-encoded, would be 200 bytes plus hash. # Removing the "encoding iso-8859-7\n" header drops 20 bytes. # Re-encoding the Pi character from \xF0 (\360) in iso-8859-7 # to \xCF\x80 (\317\200) in UTF-8 adds a byte. Check for # the expected size. - test 221 -eq "$(git cat-file -s i18n)" && + test $(($(test_oid hexsz) + 181)) -eq "$(git cat-file -s i18n)" && # ...and for the expected translation of bytes. git cat-file commit i18n >actual && grep $(printf "\317\200") actual && @@ -164,12 +165,12 @@ test_expect_success 'preserving iso-8859-7' ' sed "s/wer/i18n-no-recoding/" iso-8859-7.fi | (cd new && git fast-import && - # The commit object, if not re-encoded, is 240 bytes. + # The commit object, if not re-encoded, is 200 bytes plus hash. # Removing the "encoding iso-8859-7\n" header would drops 20 # bytes. Re-encoding the Pi character from \xF0 (\360) in # iso-8859-7 to \xCF\x80 (\317\200) in UTF-8 adds a byte. # Check for the expected size... - test 240 -eq "$(git cat-file -s i18n-no-recoding)" && + test $(($(test_oid hexsz) + 200)) -eq "$(git cat-file -s i18n-no-recoding)" && # ...as well as the expected byte. git cat-file commit i18n-no-recoding >actual && grep $(printf "\360") actual && @@ -192,7 +193,7 @@ test_expect_success 'encoding preserved if reencoding fails' ' grep ^encoding actual && # Verify that the commit has the expected size; i.e. # that no bytes were re-encoded to a different encoding. - test 252 -eq "$(git cat-file -s i18n-invalid)" && + test $(($(test_oid hexsz) + 212)) -eq "$(git cat-file -s i18n-invalid)" && # ...and check for the original special bytes grep $(printf "\360") actual && grep $(printf "\377") actual) @@ -694,7 +695,7 @@ test_expect_success 'delete ref because entire history excluded' ' git fast-export to-delete ^to-delete >actual && cat >expected <<-EOF && reset refs/heads/to-delete - from 0000000000000000000000000000000000000000 + from $ZERO_OID EOF test_cmp expected actual @@ -704,7 +705,7 @@ test_expect_success 'delete refspec' ' git fast-export --refspec :refs/heads/to-delete >actual && cat >expected <<-EOF && reset refs/heads/to-delete - from 0000000000000000000000000000000000000000 + from $ZERO_OID EOF test_cmp expected actual