From patchwork Tue Jul 28 23:34:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "brian m. carlson" X-Patchwork-Id: 11690089 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7301C14DD for ; Tue, 28 Jul 2020 23:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5150F207FC for ; Tue, 28 Jul 2020 23:35:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (3072-bit key) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b="iJoxNhDF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730281AbgG1XfT (ORCPT ); Tue, 28 Jul 2020 19:35:19 -0400 Received: from injection.crustytoothpaste.net ([192.241.140.119]:40852 "EHLO injection.crustytoothpaste.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728391AbgG1XfM (ORCPT ); Tue, 28 Jul 2020 19:35:12 -0400 Received: from camp.crustytoothpaste.net (unknown [IPv6:2001:470:b978:101:b610:a2f0:36c1:12e3]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by injection.crustytoothpaste.net (Postfix) with ESMTPSA id 1E92561021; Tue, 28 Jul 2020 23:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1595979311; bh=VEy25Puyo5VY50YZLRI+mBHlKVTAw23hM3u3rdOU7sw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Reply-To: Subject:Date:To:CC:Resent-Date:Resent-From:Resent-To:Resent-Cc: In-Reply-To:References:Content-Type:Content-Disposition; b=iJoxNhDFBA7AerdWlVs4sD3XSp5BdV68MCtirMEJOteA+RTV+1R9417Az4zib883w k3vZYd1IPZTJDVGTFUYSkno/8OFIs12vPru9z8UFe9N1WDO4ugFFTCH4T+W2QftYe3 2Qjn9jZQnRH3xC7UpEJV+MvA3nhlyiaUDGhSC3KzVE9hfTtndre1se80pWZ0EQBoi0 6JbC+S7YJEtHJkcELXFSkXcoCjssvP00nUtLZX9fZ3eGFI9/kYm4/jWTOiv5IOYhwJ /0FLOAen6NvjKjuBhxWdc8d39DRPgNvG/ME4L4pZvpJDCFI7Z0rF6q7B9U0hV6riIA weqBDKFUCYTk8VZB0btAZ3meJQyxqoKosKPbAMjwHtEDNkZlrQvZJLMK3NzNWmeT0n nAJ/x/f5Dww2L2fz4+pD1UOf4dZMnv6ISZ+9CWdcQ6iHNNQU1PmDBUL/bFEswswHI/ gztVMM0avnNrdI+uT+J/55RYZx383eQiicJyPgrLLa1f1xMuiFQ From: "brian m. carlson" To: Cc: Eric Sunshine Subject: [PATCH v5 36/39] t: make SHA1 prerequisite depend on default hash Date: Tue, 28 Jul 2020 23:34:43 +0000 Message-Id: <20200728233446.3066485-37-sandals@crustytoothpaste.net> X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6 In-Reply-To: <20200728233446.3066485-1-sandals@crustytoothpaste.net> References: <20200728233446.3066485-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Currently, the SHA1 prerequisite depends on the output of git hash-object. However, in order for that to produce sane behavior, we must be in a repository. If we are not, the default will remain SHA-1, and we'll produce wrong results if we're using SHA-256 for the testsuite but the test assertion starts when we're not in a repository. Check the environment variable we use for this purpose, leaving it to default to SHA-1 if none is specified. Signed-off-by: brian m. carlson --- t/test-lib.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 307bb2207e..b278d37d12 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1689,7 +1689,11 @@ test_lazy_prereq CURL ' # which will not work with other hash algorithms and tests that work but don't # test anything meaningful (e.g. special values which cause short collisions). test_lazy_prereq SHA1 ' - test $(git hash-object /dev/null) = e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 + case "$GIT_DEFAULT_HASH" in + sha1) true ;; + "") test $(git hash-object /dev/null) = e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 ;; + *) false :: + esac ' test_lazy_prereq REBASE_P '