From patchwork Wed Jul 29 23:14:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "brian m. carlson" X-Patchwork-Id: 11691873 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8953B13B6 for ; Wed, 29 Jul 2020 23:15:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67A8B2067D for ; Wed, 29 Jul 2020 23:15:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (3072-bit key) header.d=crustytoothpaste.net header.i=@crustytoothpaste.net header.b="A9nZSKJv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbgG2XPL (ORCPT ); Wed, 29 Jul 2020 19:15:11 -0400 Received: from injection.crustytoothpaste.net ([192.241.140.119]:41112 "EHLO injection.crustytoothpaste.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728109AbgG2XPE (ORCPT ); Wed, 29 Jul 2020 19:15:04 -0400 Received: from camp.crustytoothpaste.net (unknown [IPv6:2001:470:b978:101:b610:a2f0:36c1:12e3]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by injection.crustytoothpaste.net (Postfix) with ESMTPSA id 517A36101C; Wed, 29 Jul 2020 23:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1596064502; bh=PXksA9t4Mk9dgBX8Q6mV6mHGt+DBKXcHNHfaGS2lp9Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Reply-To: Subject:Date:To:CC:Resent-Date:Resent-From:Resent-To:Resent-Cc: In-Reply-To:References:Content-Type:Content-Disposition; b=A9nZSKJvpSCzi4cMhXrfkgWrrqck8FKzRYGCiPb5SNV5y4eH65o+xOvR0IQIG2fwo 7T/Pg7HA08bX6Q0ClScT/oIeXJiQ9Bm5ScYOvij8KFLe0Zrr0SeOEt9qGtnwkrGn0s gDv7sTThjcTCDhQUz1KL5ncxkGFXu7DezygN/+AnP+5gAK13F++mMu3dPpfFDslC2G DjWe19FazOyDm8l+MsDps33alKH6RMD70H970lxrFT4rTJNJA2cV36W1nAfoWkihZN bQVepjRitmDAjQHEaC/MxmSLH9TByrV9XjRiL4+KuqnuUCgQCiMBjjq1L4Hc7vSvIY D4ekhwINjvjwTQ8HuKAINo20XXxBrYHvkloCpWFqkBJCe87dWP0wRG5zACfUB0Inqh wSOERnn6AnjG6aa+BDAZ/6za9a8VVmUgChaDpeglq6mSa/77nPjdzBWAXmAmU+Emly vII+Jte+K1WJSTuWleRtVTFxCqsPa+AwzZbdXvPg/vEBKNj9bOm From: "brian m. carlson" To: Cc: Eric Sunshine Subject: [PATCH v6 37/39] ci: run tests with SHA-256 Date: Wed, 29 Jul 2020 23:14:26 +0000 Message-Id: <20200729231428.3658647-38-sandals@crustytoothpaste.net> X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6 In-Reply-To: <20200729231428.3658647-1-sandals@crustytoothpaste.net> References: <20200728233446.3066485-1-sandals@crustytoothpaste.net> <20200729231428.3658647-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Now that we have Git supporting SHA-256, we'd like to make sure that we don't regress that state. Unfortunately, it's easy to do so, so to help, let's add code to run one of our CI jobs with SHA-256 as the default hash. This will help us detect any problems that may occur. We pick the linux-clang job because it's relatively fast and the linux-gcc job already runs the testsuite twice. We want our tests to run as fast as possible, so we wouldn't want to add a third run to the linux-gcc job. To make sure we properly exercise the code, let's run the tests in the default mode (SHA-1) first and then run a second time with SHA-256. We explicitly specify SHA-1 for the first run so that if we change the default in the future, we make sure to test both cases. Signed-off-by: brian m. carlson --- ci/run-build-and-tests.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh index 17e25aade9..6c27b886b8 100755 --- a/ci/run-build-and-tests.sh +++ b/ci/run-build-and-tests.sh @@ -24,6 +24,12 @@ linux-gcc) export GIT_TEST_ADD_I_USE_BUILTIN=1 make test ;; +linux-clang) + export GIT_TEST_DEFAULT_HASH=sha1 + make test + export GIT_TEST_DEFAULT_HASH=sha256 + make test + ;; linux-gcc-4.8) # Don't run the tests; we only care about whether Git can be # built with GCC 4.8, as it errors out on some undesired (C99)