| Message ID | 20200731182607.15532-1-alban.gruin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4083971673cc5f05f2af257b059c8fbc25c818fb |
| Headers | show |
| Series | [v2] t6300: fix issues related to %(contents:size) | expand |
On Fri, Jul 31, 2020 at 08:26:07PM +0200, Alban Gruin wrote: > b6839fda68 (ref-filter: add support for %(contents:size), 2020-07-16) > added a new format for ref-filter, and added a function to generate > tests for this new feature in t6300. Unfortunately, it tries to run > `test_expect_sucess' instead of `test_expect_success', and writes > $expect to `expected', but tries to read `expect'. Those two issues > were probably unnoticed because the script only printed errors, but did > not crash. This fixes these issues. > > Signed-off-by: Alban Gruin <alban.gruin@gmail.com> > --- > t/t6300-for-each-ref.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good. Good eyes for spotting this, and thanks for the quick fix. -Peff
diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index ea9bb6dade..a83579fbdf 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh @@ -66,9 +66,9 @@ test_atom() { esac # Leave $expect unquoted to lose possible leading whitespaces echo $expect >expected - test_expect_${4:-sucess} $PREREQ "basic atom: $1 contents:size" ' + test_expect_${4:-success} $PREREQ "basic atom: $1 contents:size" ' git for-each-ref --format="%(contents:size)" "$ref" >actual && - test_cmp expect actual + test_cmp expected actual ' fi }
b6839fda68 (ref-filter: add support for %(contents:size), 2020-07-16) added a new format for ref-filter, and added a function to generate tests for this new feature in t6300. Unfortunately, it tries to run `test_expect_sucess' instead of `test_expect_success', and writes $expect to `expected', but tries to read `expect'. Those two issues were probably unnoticed because the script only printed errors, but did not crash. This fixes these issues. Signed-off-by: Alban Gruin <alban.gruin@gmail.com> --- t/t6300-for-each-ref.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)