Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Commit Message

Vasyl Vavrychuk Aug. 17, 2020, 12:54 p.m. UTC

Looks like Google changed gmail security and now less secure app access
needs to be explicitly enabled if 2-factor authentication is not in
place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Eric Sunshine Aug. 17, 2020, 5:16 p.m. UTC | #1

On Mon, Aug 17, 2020 at 8:54 AM Vasyl Vavrychuk <[e-mail]> wrote:
> Looks like Google changed gmail security and now less secure app access
> needs to be explicitly enabled if 2-factor authentication is not in
> place, otherwise send-mail fails with:
>
>   5.7.8 Username and Password not accepted. Learn more at
>   5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
> ---

Missing sign-off. Please see Documentation/SubmittingPatches.

> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> @@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:
> +If you do not have multifactor authentication setup on your gmail account, you
> +need to allow less secure app access. Visit
> +https://myaccount.google.com/lesssecureapps to enable it.

Thanks. Make sense. A few comments:

I think multi-factor is usually hyphenated, so perhaps:
s/multifactor/multi-factor/

Since you are not using it as a noun: s/setup/set up/

Also, Gmail is normally capitalized, so: s/gmail/Gmail

> @@ -505,7 +509,7 @@ following commands:
> -The first time you run it, you will be prompted for your credentials.  Enter the
> +The first time you run it, you will be prompted for your credentials. Enter the

This unnecessary whitespace change just adds noise to the patch, thus
should be dropped.

Patch

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..5aed3f5b1d 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -494,6 +494,10 @@  edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
+If you do not have multifactor authentication setup on your gmail account, you
+need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 If you have multifactor authentication setup on your gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
@@ -505,7 +509,7 @@  following commands:
 	$ edit outgoing/0000-*
 	$ git send-email outgoing/*
 
-The first time you run it, you will be prompted for your credentials.  Enter the
+The first time you run it, you will be prompted for your credentials. Enter the
 app-specific or your regular password as appropriate.  If you have credential
 helper configured (see linkgit:git-credential[1]), the password will be saved in
 the credential store so you won't have to type it the next time.