| Message ID | 20200826011718.3186597-2-gitster@pobox.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | War on dashed-git | expand |
On Tue, Aug 25, 2020 at 9:17 PM Junio C Hamano <gitster@pobox.com> wrote: > Runing them as "git remote-ext" and letting "git" dispatch to s/Runing/Running/ s/them/it/ > "remote-ext" would just be fine and is more idiomatic. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > diff --git a/transport-helper.c b/transport-helper.c > @@ -128,7 +128,8 @@ static struct child_process *get_helper(struct transport *transport) > - strvec_pushf(&helper->args, "git-remote-%s", data->name); > + strvec_push(&helper->args, "git"); > + strvec_pushf(&helper->args, "remote-%s", data->name); Rather than pushing "git" as the first argument, would it instead be more idiomatic to set `helper->git_cmd = 1` (or would that not work correctly for some reason)?
Hi, On Tue, 25 Aug 2020, Eric Sunshine wrote: > On Tue, Aug 25, 2020 at 9:17 PM Junio C Hamano <gitster@pobox.com> wrote: > > Runing them as "git remote-ext" and letting "git" dispatch to > > s/Runing/Running/ > s/them/it/ > > > "remote-ext" would just be fine and is more idiomatic. > > > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > > --- > > diff --git a/transport-helper.c b/transport-helper.c > > @@ -128,7 +128,8 @@ static struct child_process *get_helper(struct transport *transport) > > - strvec_pushf(&helper->args, "git-remote-%s", data->name); > > + strvec_push(&helper->args, "git"); > > + strvec_pushf(&helper->args, "remote-%s", data->name); > > Rather than pushing "git" as the first argument, would it instead be > more idiomatic to set `helper->git_cmd = 1` (or would that not work > correctly for some reason)? That is precisely what I did in Git for Windows: -- snipsnap -- From: Johannes Schindelin <johannes.schindelin@gmx.de> Subject: [PATCH] transport-helper: prefer Git's builtins over dashed form This helps with minimal installations such as MinGit that refuse to waste .zip real estate by shipping identical copies of builtins (.zip files do not support hard links). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- transport-helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index 35d6437b557..2c4b7a023db 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -130,10 +130,10 @@ static struct child_process *get_helper(struct transport *transport) helper->in = -1; helper->out = -1; helper->err = 0; - argv_array_pushf(&helper->args, "git-remote-%s", data->name); + argv_array_pushf(&helper->args, "remote-%s", data->name); argv_array_push(&helper->args, transport->remote->name); argv_array_push(&helper->args, remove_ext_force(transport->url)); - helper->git_cmd = 0; + helper->git_cmd = 1; helper->silent_exec_failure = 1; if (have_git_dir()) -- 2.28.0.windows.1.18.g5300e52e185
Eric Sunshine <sunshine@sunshineco.com> writes: > On Tue, Aug 25, 2020 at 9:17 PM Junio C Hamano <gitster@pobox.com> wrote: >> Runing them as "git remote-ext" and letting "git" dispatch to > > s/Runing/Running/ > s/them/it/ I wrote 'them' because it is not only 'ext' but other helpers are also run with the same mechanism, but the sentence uses remote-ext as a single concrete example, so 'it' would be more appropriate. Thanks. >> "remote-ext" would just be fine and is more idiomatic. >> >> Signed-off-by: Junio C Hamano <gitster@pobox.com> >> --- >> diff --git a/transport-helper.c b/transport-helper.c >> @@ -128,7 +128,8 @@ static struct child_process *get_helper(struct transport *transport) >> - strvec_pushf(&helper->args, "git-remote-%s", data->name); >> + strvec_push(&helper->args, "git"); >> + strvec_pushf(&helper->args, "remote-%s", data->name); > > Rather than pushing "git" as the first argument, would it instead be > more idiomatic to set `helper->git_cmd = 1` (or would that not work > correctly for some reason)? I was aiming for minimum change and did not think too deeply. If .git_cmd=1 works here (and offhand I do not see a reason why not), then that would be simpler. Thanks.
diff --git a/transport-helper.c b/transport-helper.c index defafbf4c1..fae3d99500 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -128,7 +128,8 @@ static struct child_process *get_helper(struct transport *transport) helper->in = -1; helper->out = -1; helper->err = 0; - strvec_pushf(&helper->args, "git-remote-%s", data->name); + strvec_push(&helper->args, "git"); + strvec_pushf(&helper->args, "remote-%s", data->name); strvec_push(&helper->args, transport->remote->name); strvec_push(&helper->args, remove_ext_force(transport->url)); helper->git_cmd = 0;
Runing them as "git remote-ext" and letting "git" dispatch to "remote-ext" would just be fine and is more idiomatic. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- transport-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)