diff mbox series

gitk: use the 'reference' format for the commit reference

Message ID 20200827161224.824365-1-dev+git@drbeat.li (mailing list archive)
State New, archived
Headers show
Series gitk: use the 'reference' format for the commit reference | expand

Commit Message

Beat Bolli Aug. 27, 2020, 4:12 p.m. UTC 
Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
the main Git repository, there's an officially blessed format for commit
references. Update gitk to also use this format.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 gitk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Eric Sunshine Aug. 27, 2020, 4:26 p.m. UTC | #1 
On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:
> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
> the main Git repository, there's an officially blessed format for commit
> references. Update gitk to also use this format.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>

See this thread:
https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/
Beat Bolli Aug. 27, 2020, 8:35 p.m. UTC | #2 
On 27.08.20 18:26, Eric Sunshine wrote:
> On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:
>> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
>> the main Git repository, there's an officially blessed format for commit
>> references. Update gitk to also use this format.
>>
>> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> 
> See this thread:
> https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/

Ooops, my memory is lacking!

Please ignore the noise...
diff mbox series

Patch

diff --git a/gitk b/gitk
index da84e22..b26996c 100755
--- a/gitk
+++ b/gitk
@@ -9433,8 +9433,7 @@  proc mktaggo {} {
 proc copyreference {} {
     global rowmenuid autosellen
 
-    set format "%h (\"%s\", %ad)"
-    set cmd [list git show -s --pretty=format:$format --date=short]
+    set cmd [list git show -s --pretty=reference]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }