diff mbox series

[2/2] config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag

Message ID 20201111095420.1446-3-avarab@gmail.com (mailing list archive)
State Accepted
Commit b990f02fd860e75629f9d6771cd3ccc48aba2c00
Headers show
Series config.mak.uname: remove unused flags | expand

Commit Message

Ævar Arnfjörð Bjarmason Nov. 11, 2020, 9:54 a.m. UTC
The NEEDS_SSL_WITH_CURL flag was still being set in one case, but
hasn't existed since 23c4bbe28e6 ("build: link with curl-defined
linker flags", 2018-11-03). Remove it, and a comment which referred to
it. See 6c109904bc8 ("Port to HP NonStop", 2012-09-19) for the initial
addition of the comment.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 config.mak.uname | 5 -----
 1 file changed, 5 deletions(-)

Comments

Randall S. Becker Nov. 11, 2020, 4:09 p.m. UTC | #1
On November 11, 2020 4:54 AM, Ævar Arnfjörð Bjarmason wrote:
> The NEEDS_SSL_WITH_CURL flag was still being set in one case, but hasn't
> existed since 23c4bbe28e6 ("build: link with curl-defined linker flags", 2018-
> 11-03). Remove it, and a comment which referred to it. See 6c109904bc8
> ("Port to HP NonStop", 2012-09-19) for the initial addition of the comment.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  config.mak.uname | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/config.mak.uname b/config.mak.uname index
> 8d7b96f8b9b..5b30a9154ac 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -541,11 +541,6 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>  	# removing the directory at OS releases J06.21 and L17.02.
>  	# Default to the older rm until those two releases are deprecated.
>  	RM = /bin/rm -f
> -	# As detected by './configure'.
> -	# Missdetected, hence commented out, see below.
> -	#NO_CURL = YesPlease
> -	# Added manually, see above.
> -	NEEDS_SSL_WITH_CURL = YesPlease
>  	NEEDS_CRYPTO_WITH_SSL = YesPlease
>  	HAVE_DEV_TTY = YesPlease
>  	HAVE_LIBCHARSET_H = YesPlease
> --
> 2.29.2.222.g5d2a92d10f8

This should be fine. We will test when rolled in, but I can't see an issue here. Sadly, I can't remove the junk above those deletions yet.

Thanks,
Randall

-- Brief whoami:
 NonStop developer since approximately 211288444200000000
 UNIX developer since approximately 421664400
-- In my real life, I talk too much.
diff mbox series

Patch

diff --git a/config.mak.uname b/config.mak.uname
index 8d7b96f8b9b..5b30a9154ac 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -541,11 +541,6 @@  ifeq ($(uname_S),NONSTOP_KERNEL)
 	# removing the directory at OS releases J06.21 and L17.02.
 	# Default to the older rm until those two releases are deprecated.
 	RM = /bin/rm -f
-	# As detected by './configure'.
-	# Missdetected, hence commented out, see below.
-	#NO_CURL = YesPlease
-	# Added manually, see above.
-	NEEDS_SSL_WITH_CURL = YesPlease
 	NEEDS_CRYPTO_WITH_SSL = YesPlease
 	HAVE_DEV_TTY = YesPlease
 	HAVE_LIBCHARSET_H = YesPlease