| Message ID | 20210817081458.53136-7-mirucam@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Finish converting git bisect to C part 4 | expand |
Hi Miriam, On Tue, 17 Aug 2021, Miriam Rubio wrote: > After reimplementation of `git bisect run` in C, > `--bisect-next-check` subcommand is not needed anymore. > > Let's remove it from options list and code. > > Mentored by: Christian Couder <chriscool@tuxfamily.org> > Signed-off-by: Miriam Rubio <mirucam@gmail.com> > --- > builtin/bisect--helper.c | 7 ------- > 1 file changed, 7 deletions(-) Exciting! This is inching closer and closer to a fully-built-in `git bisect`. Thank you so much! Dscho > > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index 852e0a30fb..d749747639 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -21,7 +21,6 @@ static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT") > > static const char * const git_bisect_helper_usage[] = { > N_("git bisect--helper --bisect-reset [<commit>]"), > - N_("git bisect--helper --bisect-next-check <good_term> <bad_term> [<term>]"), > N_("git bisect--helper --bisect-terms [--term-good | --term-old | --term-bad | --term-new]"), > N_("git bisect--helper --bisect-start [--term-{new,bad}=<term> --term-{old,good}=<term>]" > " [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<paths>...]"), > @@ -1200,12 +1199,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) > return error(_("--bisect-reset requires either no argument or a commit")); > res = bisect_reset(argc ? argv[0] : NULL); > break; > - case BISECT_NEXT_CHECK: > - if (argc != 2 && argc != 3) > - return error(_("--bisect-next-check requires 2 or 3 arguments")); > - set_terms(&terms, argv[1], argv[0]); > - res = bisect_next_check(&terms, argc == 3 ? argv[2] : NULL); > - break; > case BISECT_TERMS: > if (argc > 1) > return error(_("--bisect-terms requires 0 or 1 argument")); > -- > 2.29.2 > >
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 852e0a30fb..d749747639 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -21,7 +21,6 @@ static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT") static const char * const git_bisect_helper_usage[] = { N_("git bisect--helper --bisect-reset [<commit>]"), - N_("git bisect--helper --bisect-next-check <good_term> <bad_term> [<term>]"), N_("git bisect--helper --bisect-terms [--term-good | --term-old | --term-bad | --term-new]"), N_("git bisect--helper --bisect-start [--term-{new,bad}=<term> --term-{old,good}=<term>]" " [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<paths>...]"), @@ -1200,12 +1199,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) return error(_("--bisect-reset requires either no argument or a commit")); res = bisect_reset(argc ? argv[0] : NULL); break; - case BISECT_NEXT_CHECK: - if (argc != 2 && argc != 3) - return error(_("--bisect-next-check requires 2 or 3 arguments")); - set_terms(&terms, argv[1], argv[0]); - res = bisect_next_check(&terms, argc == 3 ? argv[2] : NULL); - break; case BISECT_TERMS: if (argc > 1) return error(_("--bisect-terms requires 0 or 1 argument"));
After reimplementation of `git bisect run` in C, `--bisect-next-check` subcommand is not needed anymore. Let's remove it from options list and code. Mentored by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Miriam Rubio <mirucam@gmail.com> --- builtin/bisect--helper.c | 7 ------- 1 file changed, 7 deletions(-)