diff mbox series

[17/41] shortlog.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status

Message ID 20220321225523.724509-18-gitter.spiros@gmail.com (mailing list archive)
State New, archived
Headers show
Series use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status | expand

Commit Message

Elia Pinto March 21, 2022, 10:54 p.m. UTC 
The C standard specifies two constants, EXIT_SUCCESS and  EXIT_FAILURE, that may
be  passed  to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.

Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 builtin/shortlog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/builtin/shortlog.c b/builtin/shortlog.c
index 26c5c0cf93..0763c94df6 100644
--- a/builtin/shortlog.c
+++ b/builtin/shortlog.c
@@ -381,7 +381,7 @@  int cmd_shortlog(int argc, const char **argv, const char *prefix)
 		case PARSE_OPT_ERROR:
 			exit(129);
 		case PARSE_OPT_COMPLETE:
-			exit(0);
+			exit(EXIT_SUCCESS);
 		case PARSE_OPT_DONE:
 			goto parse_done;
 		}