| Message ID | 20230226105303.55033-1-rybak.a.v@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c600a91c949a01548fbd8fbc70397b401f0a7747 |
| Headers | show |
| Series | [v3] test-lib: drop comment about test_description | expand |
diff --git a/t/test-lib.sh b/t/test-lib.sh index d272cca008..62136caee5 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -645,12 +645,6 @@ u200c=$(printf '\342\200\214') export _x05 _x35 LF u200c EMPTY_TREE EMPTY_BLOB ZERO_OID OID_REGEX -# Each test should start with something like this, after copyright notices: -# -# test_description='Description of this test... -# This test checks if command xyzzy does the right thing... -# ' -# . ./test-lib.sh test "x$TERM" != "xdumb" && ( test -t 1 && tput bold >/dev/null 2>&1 &&
When a comment describing how each test file should start was added in commit [1], it was the second comment of t/test-lib.sh. The comment describes how variable "test_description" is supposed to be assigned at the top of each test file and how "test-lib.sh" should be used by sourcing it. However, even in [1], the comment was ten lines away from the usage of the variable by test-lib.sh. Since then, the comment has drifted away both from the top of the file and from the usage of the variable. The comment just sits in the middle of the initialization of the test library, surrounded by unrelated code, almost one hundred lines away from the usage of "test_description". Nobody has noticed this drift during evolution of test-lib.sh, which suggests that this comment has outlived its usefulness. The assignment of "test_description", sourcing of "test-lib.sh" by tests, and the process of writing tests in general are described in detail in "t/README". So drop the obsolete comment. An alternative solution could be to move the comment either to the top of the file, or down to the usage of variable "test_description". [1] e1970ce43a ("[PATCH 1/2] Test framework take two.", 2005-05-13) Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> --- On 2023-02-25T23:50, Junio C Hamano wrote: > Andrei Rybak <rybak.a.v@gmail.com> writes: >> An alternative solution is to move the comment down to the usage of >> variable "test_description". > > Or at the beginning, as the comment is about "how you can use this > test-lib.sh test library in your tests". Here's v3 with updated description of the dropped comment and updated description of the alternative solution. > I have no strong preference. Just dropping it sounds easier, as a > more readable description already exists elsewhere. Also, at the top of "test-lib.sh", there is a comment pointing to that other place: # Test framework for git. See t/README for usage. added in c74c72034f (test: replace shebangs with descriptions in shell libraries, 2013-11-25). t/test-lib.sh | 6 ------ 1 file changed, 6 deletions(-)