| Message ID | 20230418175034.982433-2-rybak.a.v@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | git config tests for "'git config ignores pairs ..." | expand |
Andrei Rybak <rybak.a.v@gmail.com> writes: > There are two almost identical tests called 'git config ignores pairs > with zero count' in file t1300-config.sh. Drop the first of these and > keep the one that contains more assertions. Good eyes. I can see that the other one catches the error output from the identical command and makes sure it exits silently. Will queue. Thanks. > Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> > --- > t/t1300-config.sh | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/t/t1300-config.sh b/t/t1300-config.sh > index 2575279ab8..696dca17c6 100755 > --- a/t/t1300-config.sh > +++ b/t/t1300-config.sh > @@ -1458,13 +1458,6 @@ test_expect_success 'git config ignores pairs without count' ' > test_must_be_empty error > ' > > -test_expect_success 'git config ignores pairs with zero count' ' > - test_must_fail env \ > - GIT_CONFIG_COUNT=0 \ > - GIT_CONFIG_KEY_0="pair.one" GIT_CONFIG_VALUE_0="value" \ > - git config pair.one > -' > - > test_expect_success 'git config ignores pairs exceeding count' ' > GIT_CONFIG_COUNT=1 \ > GIT_CONFIG_KEY_0="pair.one" GIT_CONFIG_VALUE_0="value" \
diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 2575279ab8..696dca17c6 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1458,13 +1458,6 @@ test_expect_success 'git config ignores pairs without count' ' test_must_be_empty error ' -test_expect_success 'git config ignores pairs with zero count' ' - test_must_fail env \ - GIT_CONFIG_COUNT=0 \ - GIT_CONFIG_KEY_0="pair.one" GIT_CONFIG_VALUE_0="value" \ - git config pair.one -' - test_expect_success 'git config ignores pairs exceeding count' ' GIT_CONFIG_COUNT=1 \ GIT_CONFIG_KEY_0="pair.one" GIT_CONFIG_VALUE_0="value" \
There are two almost identical tests called 'git config ignores pairs with zero count' in file t1300-config.sh. Drop the first of these and keep the one that contains more assertions. Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> --- t/t1300-config.sh | 7 ------- 1 file changed, 7 deletions(-)