diff mbox series

[v2,07/22] ls-tree: mark unused parameter in callback

Message ID	20230829234519.GE227214@coredump.intra.peff.net (mailing list archive)
State	Accepted
Commit	c5cb97cbbf794df9279d408d22ef756504812135
Headers	show Return-Path: <git-owner@vger.kernel.org> Date: Tue, 29 Aug 2023 19:45:19 -0400 From: Jeff King <peff@peff.net> To: git@vger.kernel.org Cc: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>, Phillip Wood <phillip.wood@dunelm.org.uk> Subject: [PATCH v2 07/22] ls-tree: mark unused parameter in callback Message-ID: <20230829234519.GE227214@coredump.intra.peff.net> References: <20230829234305.GA226944@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230829234305.GA226944@coredump.intra.peff.net> Precedence: bulk
Series	Yet Another Unused Parameter Series \| expand [v2,0/22] Yet Another Unused Parameter Series [v2,01/22] sequencer: use repository parameter in short_commit_name() [v2,02/22] sequencer: mark repository argument as unused [v2,03/22] ref-filter: mark unused parameters in parser callbacks [v2,04/22] pack-bitmap: mark unused parameters in show_object callback [v2,05/22] worktree: mark unused parameters in each_ref_fn callback [v2,06/22] commit-graph: mark unused data parameters in generation callbacks [v2,07/22] ls-tree: mark unused parameter in callback [v2,08/22] stash: mark unused parameter in diff callback [v2,09/22] trace2: mark unused us_elapsed_absolute parameters [v2,10/22] trace2: mark unused config callback parameter [v2,11/22] test-trace2: mark unused argv/argc parameters [v2,12/22] grep: mark unused parameter in output function [v2,13/22] add-interactive: mark unused callback parameters [v2,14/22] negotiator/noop: mark unused callback parameters [v2,15/22] worktree: mark unused parameters in noop repair callback [v2,16/22] imap-send: mark unused parameters with NO_OPENSSL [v2,17/22] grep: mark unused parmaeters in pcre fallbacks [v2,18/22] credential: mark unused parameter in urlmatch callback [v2,19/22] fetch: mark unused parameter in ref_transaction callback [v2,20/22] bundle-uri: mark unused parameters in callbacks [v2,21/22] gc: mark unused descriptors in scheduler callbacks [v2,22/22] update-ref: mark unused parameter in parser callbacks

Commit Message

Jeff King Aug. 29, 2023, 11:45 p.m. UTC

The formatting functions are dispatched from a table of function
pointers. The "path name only" function unsurprisingly does not need to
look at its "oid" parameter, but we must mark it as unused to make
-Wunused-parameter happy.

Signed-off-by: Jeff King <peff@peff.net>
---
 builtin/ls-tree.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
index f558db5f3b..209d2dc0d5 100644
--- a/builtin/ls-tree.c
+++ b/builtin/ls-tree.c
@@ -241,7 +241,8 @@  static int show_tree_long(const struct object_id *oid, struct strbuf *base,
 	return recurse;
 }
 
-static int show_tree_name_only(const struct object_id *oid, struct strbuf *base,
+static int show_tree_name_only(const struct object_id *oid UNUSED,
+			       struct strbuf *base,
 			       const char *pathname, unsigned mode,
 			       void *context)
 {