diff mbox series

[v2,20/22] bundle-uri: mark unused parameters in callbacks

Message ID	20230829234539.GR227214@coredump.intra.peff.net (mailing list archive)
State	Accepted
Commit	fd3fe4914a59df93aeb67572d8932d2ae4cedb0d
Headers	show Return-Path: <git-owner@vger.kernel.org> Date: Tue, 29 Aug 2023 19:45:39 -0400 From: Jeff King <peff@peff.net> To: git@vger.kernel.org Cc: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>, Phillip Wood <phillip.wood@dunelm.org.uk> Subject: [PATCH v2 20/22] bundle-uri: mark unused parameters in callbacks Message-ID: <20230829234539.GR227214@coredump.intra.peff.net> References: <20230829234305.GA226944@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230829234305.GA226944@coredump.intra.peff.net> Precedence: bulk
Series	Yet Another Unused Parameter Series \| expand [v2,0/22] Yet Another Unused Parameter Series [v2,01/22] sequencer: use repository parameter in short_commit_name() [v2,02/22] sequencer: mark repository argument as unused [v2,03/22] ref-filter: mark unused parameters in parser callbacks [v2,04/22] pack-bitmap: mark unused parameters in show_object callback [v2,05/22] worktree: mark unused parameters in each_ref_fn callback [v2,06/22] commit-graph: mark unused data parameters in generation callbacks [v2,07/22] ls-tree: mark unused parameter in callback [v2,08/22] stash: mark unused parameter in diff callback [v2,09/22] trace2: mark unused us_elapsed_absolute parameters [v2,10/22] trace2: mark unused config callback parameter [v2,11/22] test-trace2: mark unused argv/argc parameters [v2,12/22] grep: mark unused parameter in output function [v2,13/22] add-interactive: mark unused callback parameters [v2,14/22] negotiator/noop: mark unused callback parameters [v2,15/22] worktree: mark unused parameters in noop repair callback [v2,16/22] imap-send: mark unused parameters with NO_OPENSSL [v2,17/22] grep: mark unused parmaeters in pcre fallbacks [v2,18/22] credential: mark unused parameter in urlmatch callback [v2,19/22] fetch: mark unused parameter in ref_transaction callback [v2,20/22] bundle-uri: mark unused parameters in callbacks [v2,21/22] gc: mark unused descriptors in scheduler callbacks [v2,22/22] update-ref: mark unused parameter in parser callbacks

Commit Message

Jeff King Aug. 29, 2023, 11:45 p.m. UTC

The first hunk is similar to 02c3c59e62 (hashmap: mark unused callback
parameters, 2022-08-19), but was added after that commit.

The other two are used with for_all_bundles_in_list(), but don't use
their void data pointer.

Signed-off-by: Jeff King <peff@peff.net>
---
 bundle-uri.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/bundle-uri.c b/bundle-uri.c
index 4b5c49b93d..8492fffd2f 100644
--- a/bundle-uri.c
+++ b/bundle-uri.c
@@ -20,7 +20,7 @@  static struct {
 	{ BUNDLE_HEURISTIC_CREATIONTOKEN, "creationToken" },
 };
 
-static int compare_bundles(const void *hashmap_cmp_fn_data,
+static int compare_bundles(const void *hashmap_cmp_fn_data UNUSED,
 			   const struct hashmap_entry *he1,
 			   const struct hashmap_entry *he2,
 			   const void *id)
@@ -45,7 +45,7 @@  void init_bundle_list(struct bundle_list *list)
 }
 
 static int clear_remote_bundle_info(struct remote_bundle_info *bundle,
-				    void *data)
+				    void *data UNUSED)
 {
 	FREE_AND_NULL(bundle->id);
 	FREE_AND_NULL(bundle->uri);
@@ -779,7 +779,7 @@  static int unbundle_all_bundles(struct repository *r,
 	return 0;
 }
 
-static int unlink_bundle(struct remote_bundle_info *info, void *data)
+static int unlink_bundle(struct remote_bundle_info *info, void *data UNUSED)
 {
 	if (info->file)
 		unlink_or_warn(info->file);