| Message ID | 20240227150934.7950-3-randall.becker@nexbridge.ca (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Change xwrite() to write_in_full() in builtins. | expand |
"Randall S. Becker" <the.n.e.key@gmail.com> writes: > From: "Randall S. Becker" <rsbecker@nexbridge.com> > > This change is required because some platforms do not support file writes of arbitrary sizes (e.g, NonStop). xwrite ends up truncating the output to the > maximum single I/O size possible for the destination device. > > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com> > --- > builtin/receive-pack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c > index db65607485..4277c63d08 100644 > --- a/builtin/receive-pack.c > +++ b/builtin/receive-pack.c > @@ -456,7 +456,7 @@ static void report_message(const char *prefix, const char *err, va_list params) > if (use_sideband) > send_sideband(1, 2, msg, sz, use_sideband); > else > - xwrite(2, msg, sz); > + write_in_full(2, msg, sz); > } This change does make sense, as we can see a short write(2) from xwrite() and this caller is not repeating the call to flush the remainder after a short write. > > __attribute__((format (printf, 1, 2)))
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index db65607485..4277c63d08 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -456,7 +456,7 @@ static void report_message(const char *prefix, const char *err, va_list params) if (use_sideband) send_sideband(1, 2, msg, sz, use_sideband); else - xwrite(2, msg, sz); + write_in_full(2, msg, sz); } __attribute__((format (printf, 1, 2)))