| Message ID | 20240307093005.GN2080210@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | allow multi-byte core.commentChar | expand |
diff --git a/environment.h b/environment.h index 3496474cce..a8b06674eb 100644 --- a/environment.h +++ b/environment.h @@ -8,7 +8,6 @@ struct strvec; * The character that begins a commented line in user-editable file * that is subject to stripspace. */ -#define comment_line_char (comment_line_str[0]) extern const char *comment_line_str; extern int auto_comment_line_char;
There is no longer any code which references the single-byte comment_line_char. Let's drop it, clearing the way for true multi-byte entries in comment_line_str. It's possible there are topics in flight that have added new references to comment_line_char. But we would prefer to fail compilation (and then fix it) upon merging with this, rather than have them quietly ignore the bytes after the first. Signed-off-by: Jeff King <peff@peff.net> --- I did merge against 'next' and there are no such topics. And likewise "log -Scomment_line_char next..seen" shows nothing. But as somebody who maintained a long-running fork for many years, who knows what people are carrying in their private trees. ;) environment.h | 1 - 1 file changed, 1 deletion(-)