[v2,10/22] t/t5*: avoid redundant uses of cat

Message ID	20240315194620.10713-11-dev+git@drbeat.li (mailing list archive)
State	Accepted
Commit	f636d25dc48d2a1fc2951c098d942fdf190da9f9
Headers	show Received: from mail-gateway-shared03.cyon.net (mail-gateway-shared03.cyon.net [194.126.200.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92739548EF for <git@vger.kernel.org>; Fri, 15 Mar 2024 19:46:45 +0000 (UTC) From: "Beat Bolli" <bb@drbeat.li> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Beat Bolli <dev+git@drbeat.li> Subject: [PATCH v2 10/22] t/t5*: avoid redundant uses of cat Date: Fri, 15 Mar 2024 20:46:07 +0100 Message-ID: <20240315194620.10713-11-dev+git@drbeat.li> In-Reply-To: <20240315194620.10713-1-dev+git@drbeat.li> References: <20240305212533.12947-1-dev+git@drbeat.li> <20240315194620.10713-1-dev+git@drbeat.li> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	avoid redundant pipelines \| expand [v2,00/22] avoid redundant pipelines [v2,01/22] doc: avoid redundant use of cat [v2,02/22] contrib/subtree/t: avoid redundant use of cat [v2,03/22] t/lib-cvs.sh: avoid redundant use of cat [v2,04/22] t/annotate-tests.sh: avoid redundant use of cat [v2,05/22] t/perf: avoid redundant use of cat [v2,06/22] t/t0: avoid redundant uses of cat [v2,07/22] t/t1: avoid redundant uses of cat [v2,08/22] t/t3: avoid redundant uses of cat [v2,09/22] t/t4: avoid redundant uses of cat [v2,10/22] t/t5: avoid redundant uses of cat [v2,11/22] t/t6: avoid redundant uses of cat [v2,12/22] t/t7: avoid redundant use of cat [v2,13/22] t/t8: avoid redundant use of cat [v2,14/22] t/t9: avoid redundant uses of cat [v2,15/22] t/t1: merge a "grep \| sed" pipeline [v2,16/22] t/t3: merge a "grep \| awk" pipeline [v2,17/22] t/t4: merge a "grep \| sed" pipeline [v2,18/22] t/t5: merge a "grep \| sed" pipeline [v2,19/22] t/t8: merge "grep \| sed" pipelines [v2,20/22] t/t9*: merge "grep \| sed" pipelines [v2,21/22] contrib/coverage-diff: avoid redundant pipelines [v2,22/22] git-quiltimport: avoid an unnecessary subshell

Message ID

20240315194620.10713-11-dev+git@drbeat.li (mailing list archive)

State

Accepted

Commit

f636d25dc48d2a1fc2951c098d942fdf190da9f9

Headers

From: "Beat Bolli" <bb@drbeat.li>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Beat Bolli <dev+git@drbeat.li>
Subject: [PATCH v2 10/22] t/t5*: avoid redundant uses of cat
Date: Fri, 15 Mar 2024 20:46:07 +0100
Message-ID: <20240315194620.10713-11-dev+git@drbeat.li>
In-Reply-To: <20240315194620.10713-1-dev+git@drbeat.li>
References: <20240305212533.12947-1-dev+git@drbeat.li>
 <20240315194620.10713-1-dev+git@drbeat.li>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

avoid redundant pipelines | expand

Commit Message

Beat Bolli March 15, 2024, 7:46 p.m. UTC

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 t/t5100-mailinfo.sh                    | 2 +-
 t/t5317-pack-objects-filter-objects.sh | 2 +-
 t/t5534-push-signed.sh                 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh
index 654d8cf3ee00..c8d06554541c 100755
--- a/t/t5100-mailinfo.sh
+++ b/t/t5100-mailinfo.sh
@@ -70,7 +70,7 @@  test_expect_success 'respect NULs' '
 
 	git mailsplit -d3 -o. "$DATA/nul-plain" &&
 	test_cmp "$DATA/nul-plain" 001 &&
-	(cat 001 | git mailinfo msg patch) &&
+	git mailinfo msg patch <001 &&
 	test_line_count = 4 patch
 
 '
diff --git a/t/t5317-pack-objects-filter-objects.sh b/t/t5317-pack-objects-filter-objects.sh
index 2ff3eef9a3b8..79552d6ef7f6 100755
--- a/t/t5317-pack-objects-filter-objects.sh
+++ b/t/t5317-pack-objects-filter-objects.sh
@@ -455,7 +455,7 @@  test_expect_success 'setup r1 - delete loose blobs' '
 	test_parse_ls_files_stage_oids <ls_files_result |
 	sort >expected &&
 
-	for id in `cat expected | sed "s|..|&/|"`
+	for id in `sed "s|..|&/|" expected`
 	do
 		rm r1/.git/objects/$id || return 1
 	done
diff --git a/t/t5534-push-signed.sh b/t/t5534-push-signed.sh
index b4bc24691c81..c91a62b77afc 100755
--- a/t/t5534-push-signed.sh
+++ b/t/t5534-push-signed.sh
@@ -303,7 +303,7 @@  test_expect_success GPGSM 'fail without key and heed user.signingkey x509' '
 		EOF
 		sed -n -e "s/^nonce /NONCE=/p" -e "/^$/q" dst/push-cert
 	) >expect.in &&
-	key=$(cat "${GNUPGHOME}/trustlist.txt" | cut -d" " -f1 | tr -d ":") &&
+	key=$(cut -d" " -f1 <"${GNUPGHOME}/trustlist.txt" | tr -d ":") &&
 	sed -e "s/^KEY=/KEY=${key}/" expect.in >expect &&
 
 	noop=$(git rev-parse noop) &&

[v2,10/22] t/t5*: avoid redundant uses of cat

Commit Message

Patch