[v2,07/22] t/t1*: avoid redundant uses of cat

Message ID	20240315194620.10713-8-dev+git@drbeat.li (mailing list archive)
State	Accepted
Commit	2ed139ccc935f9bacc670e7be32694657918e84d
Headers	show Received: from mail-gateway-shared03.cyon.net (mail-gateway-shared03.cyon.net [194.126.200.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5008654747 for <git@vger.kernel.org>; Fri, 15 Mar 2024 19:46:41 +0000 (UTC) From: "Beat Bolli" <bb@drbeat.li> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Beat Bolli <dev+git@drbeat.li> Subject: [PATCH v2 07/22] t/t1*: avoid redundant uses of cat Date: Fri, 15 Mar 2024 20:46:04 +0100 Message-ID: <20240315194620.10713-8-dev+git@drbeat.li> In-Reply-To: <20240315194620.10713-1-dev+git@drbeat.li> References: <20240305212533.12947-1-dev+git@drbeat.li> <20240315194620.10713-1-dev+git@drbeat.li> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	avoid redundant pipelines \| expand [v2,00/22] avoid redundant pipelines [v2,01/22] doc: avoid redundant use of cat [v2,02/22] contrib/subtree/t: avoid redundant use of cat [v2,03/22] t/lib-cvs.sh: avoid redundant use of cat [v2,04/22] t/annotate-tests.sh: avoid redundant use of cat [v2,05/22] t/perf: avoid redundant use of cat [v2,06/22] t/t0: avoid redundant uses of cat [v2,07/22] t/t1: avoid redundant uses of cat [v2,08/22] t/t3: avoid redundant uses of cat [v2,09/22] t/t4: avoid redundant uses of cat [v2,10/22] t/t5: avoid redundant uses of cat [v2,11/22] t/t6: avoid redundant uses of cat [v2,12/22] t/t7: avoid redundant use of cat [v2,13/22] t/t8: avoid redundant use of cat [v2,14/22] t/t9: avoid redundant uses of cat [v2,15/22] t/t1: merge a "grep \| sed" pipeline [v2,16/22] t/t3: merge a "grep \| awk" pipeline [v2,17/22] t/t4: merge a "grep \| sed" pipeline [v2,18/22] t/t5: merge a "grep \| sed" pipeline [v2,19/22] t/t8: merge "grep \| sed" pipelines [v2,20/22] t/t9*: merge "grep \| sed" pipelines [v2,21/22] contrib/coverage-diff: avoid redundant pipelines [v2,22/22] git-quiltimport: avoid an unnecessary subshell

Message ID

20240315194620.10713-8-dev+git@drbeat.li (mailing list archive)

State

Accepted

Commit

2ed139ccc935f9bacc670e7be32694657918e84d

Headers

From: "Beat Bolli" <bb@drbeat.li>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Beat Bolli <dev+git@drbeat.li>
Subject: [PATCH v2 07/22] t/t1*: avoid redundant uses of cat
Date: Fri, 15 Mar 2024 20:46:04 +0100
Message-ID: <20240315194620.10713-8-dev+git@drbeat.li>
In-Reply-To: <20240315194620.10713-1-dev+git@drbeat.li>
References: <20240305212533.12947-1-dev+git@drbeat.li>
 <20240315194620.10713-1-dev+git@drbeat.li>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

avoid redundant pipelines | expand

Commit Message

Beat Bolli March 15, 2024, 7:46 p.m. UTC

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 t/t1007-hash-object.sh             | 6 +++---
 t/t1091-sparse-checkout-builtin.sh | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t1007-hash-object.sh b/t/t1007-hash-object.sh
index ac3d173767ae..64aea3848606 100755
--- a/t/t1007-hash-object.sh
+++ b/t/t1007-hash-object.sh
@@ -124,8 +124,8 @@  test_expect_success 'check that appropriate filter is invoke when --path is used
 	path0_sha=$(git hash-object --path=file0 file1) &&
 	test "$file0_sha" = "$path0_sha" &&
 	test "$file1_sha" = "$path1_sha" &&
-	path1_sha=$(cat file0 | git hash-object --path=file1 --stdin) &&
-	path0_sha=$(cat file1 | git hash-object --path=file0 --stdin) &&
+	path1_sha=$(git hash-object --path=file1 --stdin <file0) &&
+	path0_sha=$(git hash-object --path=file0 --stdin <file1) &&
 	test "$file0_sha" = "$path0_sha" &&
 	test "$file1_sha" = "$path1_sha"
 '
@@ -154,7 +154,7 @@  test_expect_success '--path works in a subdirectory' '
 test_expect_success 'check that --no-filters option works' '
 	nofilters_file1=$(git hash-object --no-filters file1) &&
 	test "$file0_sha" = "$nofilters_file1" &&
-	nofilters_file1=$(cat file1 | git hash-object --stdin) &&
+	nofilters_file1=$(git hash-object --stdin <file1) &&
 	test "$file0_sha" = "$nofilters_file1"
 '
 
diff --git a/t/t1091-sparse-checkout-builtin.sh b/t/t1091-sparse-checkout-builtin.sh
index e49b8024ac53..ab3a105ffff2 100755
--- a/t/t1091-sparse-checkout-builtin.sh
+++ b/t/t1091-sparse-checkout-builtin.sh
@@ -968,7 +968,7 @@  test_expect_success 'check-rules non-cone mode' '
 	git -C bare sparse-checkout check-rules --no-cone --rules-file ../rules\
 		>check-rules-file <all-files &&
 
-	cat rules | git -C repo sparse-checkout set --no-cone --stdin &&
+	git -C repo sparse-checkout set --no-cone --stdin <rules &&
 	git -C repo ls-files -t >out &&
 	sed -n "/^S /!s/^. //p" out >ls-files &&

[v2,07/22] t/t1*: avoid redundant uses of cat

Commit Message

Patch