[03/12] ci: drop mention of BREW_INSTALL_PACKAGES variable

Message ID	20240521195659.870714-4-gitster@pobox.com (mailing list archive)
State	Superseded
Headers	show Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 052C21494CC for <git@vger.kernel.org>; Tue, 21 May 2024 19:57:12 +0000 (UTC) From: Junio C Hamano <gitster@pobox.com> To: git@vger.kernel.org Cc: Jeff King <peff@peff.net> Subject: [PATCH 03/12] ci: drop mention of BREW_INSTALL_PACKAGES variable Date: Tue, 21 May 2024 12:56:49 -0700 Message-ID: <20240521195659.870714-4-gitster@pobox.com> In-Reply-To: <20240521195659.870714-1-gitster@pobox.com> References: <20240521195659.870714-1-gitster@pobox.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
Series	Fix various overly aggressive protections in 2.45.1 and friends \| expand [00/12] Fix various overly aggressive protections in 2.45.1 and friends [01/12] send-email: drop FakeTerm hack [02/12] send-email: avoid creating more than one Term::ReadLine object [03/12] ci: drop mention of BREW_INSTALL_PACKAGES variable [04/12] ci: avoid bare "gcc" for osx-gcc job [05/12] ci: stop installing "gcc-13" for osx-gcc [06/12] hook: plug a new memory leak [07/12] init: use the correct path of the templates directory again [08/12] Revert "core.hooksPath: add some protection while cloning" [09/12] tests: verify that `clone -c core.hooksPath=/dev/null` works again [10/12] clone: drop the protections where hooks aren't run [11/12] Revert "Add a helper function to compare file contents" [12/12] Revert "fetch/clone: detect dubious ownership of local repositories" [rPATCH,13/12] Merge branch 'jc/fix-aggressive-protection-2.39' [rPATCH,14/12] Merge branch 'jc/fix-aggressive-protection-2.40'

Message ID

20240521195659.870714-4-gitster@pobox.com (mailing list archive)

State

Superseded

Headers

From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: [PATCH 03/12] ci: drop mention of BREW_INSTALL_PACKAGES variable
Date: Tue, 21 May 2024 12:56:49 -0700
Message-ID: <20240521195659.870714-4-gitster@pobox.com>
In-Reply-To: <20240521195659.870714-1-gitster@pobox.com>
References: <20240521195659.870714-1-gitster@pobox.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Series

Fix various overly aggressive protections in 2.45.1 and friends | expand

Commit Message

Junio C Hamano May 21, 2024, 7:56 p.m. UTC

From: Jeff King <peff@peff.net>

The last user of this variable went away in 4a6e4b9602 (CI: remove
Travis CI support, 2021-11-23), so it's doing nothing except making it
more confusing to find out which packages _are_ installed.

[jc: cherry-picked from v2.45.0-1-g9d4453e8d6]

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ci/install-dependencies.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 4f407530d3..33039d516b 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -34,8 +34,6 @@  macos-*)
 	export HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_CLEANUP=1
 	# Uncomment this if you want to run perf tests:
 	# brew install gnu-time
-	test -z "$BREW_INSTALL_PACKAGES" ||
-	brew install $BREW_INSTALL_PACKAGES
 	brew link --force gettext
 	mkdir -p $HOME/bin
 	(

[03/12] ci: drop mention of BREW_INSTALL_PACKAGES variable

Commit Message

Patch