| Message ID | 20240604101305.GA1304593@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2181fe6e464c4a2615db0df1189d1e6fb0575631 |
| Headers | show |
| Series | leak fixes for sparse-checkout code | expand |
diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c index 0f52e25249..8747191484 100644 --- a/builtin/sparse-checkout.c +++ b/builtin/sparse-checkout.c @@ -311,6 +311,8 @@ static void write_cone_to_file(FILE *fp, struct pattern_list *pl) fprintf(fp, "%s/\n", pattern); free(pattern); } + + string_list_clear(&sl, 0); } static int write_patterns_and_update(struct pattern_list *pl)
We use a string list to hold sorted and de-duped patterns, but don't free it before leaving the function, causing a leak. This drops the number of leaks found in t7002 from 27 to 25. Signed-off-by: Jeff King <peff@peff.net> --- builtin/sparse-checkout.c | 2 ++ 1 file changed, 2 insertions(+)