| Message ID | 20240608183747.2084294-3-gitster@pobox.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f52c9a2a280e872546ed84dcea71723d9a762d9a |
| Headers | show |
| Series | varargs functions with __attributes__(()) | expand |
diff --git a/config.c b/config.c index abce05b774..ea355f28ec 100644 --- a/config.c +++ b/config.c @@ -2844,7 +2844,6 @@ void git_die_config_linenr(const char *key, const char *filename, int linenr) key, filename, linenr); } -NORETURN __attribute__((format(printf, 2, 3))) void git_die_config(const char *key, const char *err, ...) { const struct string_list *values;
The convention is to declare the function attribute to an extern function together with its declaration in the header file, without repeating the attribute declaration with its definition in the .c source file (a file-scope static function declares its attribute together with its definition in the .c file it is defined, as there is no other place to do so). The definition of git_die_config() in config.c did not follow the convention and had its attribute declared with both its declaration in the header and its definition in the .c source file. Remove the one in the config.c to match everybody else. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- config.c | 1 - 1 file changed, 1 deletion(-)