diff mbox series

[08/11] t-reftable-record: add reftable_record_is_deletion() test for obj records

Message ID 20240621060018.12795-9-chandrapratap3519@gmail.com (mailing list archive)
State Superseded
Headers show
Series t: port reftable/record_test.c to the unit testing framework | expand

Commit Message

Chandra Pratap June 21, 2024, 5:47 a.m. UTC 
reftable_record_is_deletion() is a function defined in
reftable/record.{c, h} which determines whether a record is of
type deletion or not. Since obj records can never be of type deletion,
this function must always return 0 when called on an obj record.
In the current testing setup for obj records, this functionality is
left untested. Add a test for the same.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
 t/unit-tests/t-reftable-record.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/t/unit-tests/t-reftable-record.c b/t/unit-tests/t-reftable-record.c
index 70c1db6756..204a673260 100644
--- a/t/unit-tests/t-reftable-record.c
+++ b/t/unit-tests/t-reftable-record.c
@@ -389,6 +389,7 @@  static void test_reftable_obj_record_roundtrip(void)
 		int n, m;
 		uint8_t extra;
 
+		check(!reftable_record_is_deletion(&in));
 		test_copy(&in);
 		reftable_record_key(&in, &key);
 		n = reftable_record_encode(&in, dest, GIT_SHA1_RAWSZ);