[v3,05/15] config.mak.dev: drop `-Wno-sign-compare`

Message ID	20241205-pks-sign-compare-v3-5-e211ee089717@pks.im (mailing list archive)
State	Superseded
Headers	show Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2B991D5CEE for <git@vger.kernel.org>; Thu, 5 Dec 2024 09:36:54 +0000 (UTC) Feedback-ID: i197146af:Fastmail From: Patrick Steinhardt <ps@pks.im> Date: Thu, 05 Dec 2024 10:36:27 +0100 Subject: [PATCH v3 05/15] config.mak.dev: drop `-Wno-sign-compare` Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20241205-pks-sign-compare-v3-5-e211ee089717@pks.im> References: <20241205-pks-sign-compare-v3-0-e211ee089717@pks.im> In-Reply-To: <20241205-pks-sign-compare-v3-0-e211ee089717@pks.im> To: git@vger.kernel.org Cc: shejialuo <shejialuo@gmail.com>, Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Series	Start compiling with `-Wsign-compare` \| expand [v3,00/15] Start compiling with `-Wsign-compare` [v3,01/15] git-compat-util: introduce macros to disable "-Wsign-compare" warnings [v3,02/15] compat/regex: explicitly ignore "-Wsign-compare" warnings [v3,03/15] compat/win32: fix -Wsign-compare warning in "wWinMain()" [v3,04/15] global: mark code units that generate warnings with `-Wsign-compare` [v3,05/15] config.mak.dev: drop `-Wno-sign-compare` [v3,06/15] diff.h: fix index used to loop through unsigned integer [v3,07/15] sign-compare: 32-bit support [v3,08/15] global: trivial conversions to fix `-Wsign-compare` warnings [v3,09/15] daemon: fix loops that have mismatching integer types [v3,10/15] daemon: fix type of `max_connections` [v3,11/15] gpg-interface: address -Wsign-comparison warnings [v3,12/15] builtin/blame: fix type of `length` variable when emitting object ID [v3,13/15] builtin/patch-id: fix type of `get_one_patchid()` [v3,14/15] scalar: address -Wsign-compare warnings [v3,15/15] t/helper: don't depend on implicit wraparound

Message ID

20241205-pks-sign-compare-v3-5-e211ee089717@pks.im (mailing list archive)

State

Superseded

Headers

Feedback-ID: i197146af:Fastmail
From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 05 Dec 2024 10:36:27 +0100
Subject: [PATCH v3 05/15] config.mak.dev: drop `-Wno-sign-compare`
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20241205-pks-sign-compare-v3-5-e211ee089717@pks.im>
References: <20241205-pks-sign-compare-v3-0-e211ee089717@pks.im>
In-Reply-To: <20241205-pks-sign-compare-v3-0-e211ee089717@pks.im>
To: git@vger.kernel.org
Cc: shejialuo <shejialuo@gmail.com>, Jeff King <peff@peff.net>,
 Junio C Hamano <gitster@pobox.com>

Series

Start compiling with `-Wsign-compare` | expand

Commit Message

Patrick Steinhardt Dec. 5, 2024, 9:36 a.m. UTC

There is no need anymore to disable `-Wsign-compare` now that all files
that cause warnings have been marked accordingly. Drop the option.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 config.mak.dev | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config.mak.dev b/config.mak.dev
index 8eca7fa22823b46ebdf02b73d53031784fd5ba2a..0fd8cc4d355ebb7428e1d8258154926dedf8827b 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -53,7 +53,6 @@  ifeq ($(filter extra-all,$(DEVOPTS)),)
 # These are disabled because we have these all over the place.
 DEVELOPER_CFLAGS += -Wno-empty-body
 DEVELOPER_CFLAGS += -Wno-missing-field-initializers
-DEVELOPER_CFLAGS += -Wno-sign-compare
 endif
 endif

[v3,05/15] config.mak.dev: drop `-Wno-sign-compare`

Commit Message

Patch