diff mbox series

[GSoC,2/2] t4018: add tests for gitconfig in userdiff

Message ID 20250319172016.2115-3-lucasseikioshiro@gmail.com (mailing list archive)
State New
Headers show
Series add userdiff driver for gitconfig | expand

Commit Message

Lucas Seiki Oshiro March 19, 2025, 5:20 p.m. UTC
Add userdiff tests for gitconfig files. These files define sections and
subsections, with and without indentation.

Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
 t/t4018/gitconfig-section             | 5 +++++
 t/t4018/gitconfig-section-noindent    | 5 +++++
 t/t4018/gitconfig-subsection          | 7 +++++++
 t/t4018/gitconfig-subsection-noindent | 7 +++++++
 4 files changed, 24 insertions(+)
 create mode 100644 t/t4018/gitconfig-section
 create mode 100644 t/t4018/gitconfig-section-noindent
 create mode 100644 t/t4018/gitconfig-subsection
 create mode 100644 t/t4018/gitconfig-subsection-noindent

Comments

Patrick Steinhardt March 20, 2025, 8:38 a.m. UTC | #1
On Wed, Mar 19, 2025 at 02:20:16PM -0300, Lucas Seiki Oshiro wrote:
> Add userdiff tests for gitconfig files. These files define sections and
> subsections, with and without indentation.

I think it would make sense to suqash this commit into the first one.

> diff --git a/t/t4018/gitconfig-section b/t/t4018/gitconfig-section
> new file mode 100644
> index 0000000000..866aa70b24
> --- /dev/null
> +++ b/t/t4018/gitconfig-section
> @@ -0,0 +1,5 @@
> +[RIGHT]
> +        # comment
> +        ; comment
> +        name = value
> +        ChangeMe
> \ No newline at end of file

You're missing newlines at the end of al test files. I don't think this
is intentional, is it?

Patrick
Lucas Seiki Oshiro March 23, 2025, 4:08 p.m. UTC | #2
> I think it would make sense to suqash this commit into the first one.

Ok! I'll do that in a v2.

> You're missing newlines at the end of al test files. I don't think this
> is intentional, is it?

No... somehow my text editor is not configured to do that. I'll fix it.
diff mbox series

Patch

diff --git a/t/t4018/gitconfig-section b/t/t4018/gitconfig-section
new file mode 100644
index 0000000000..866aa70b24
--- /dev/null
+++ b/t/t4018/gitconfig-section
@@ -0,0 +1,5 @@ 
+[RIGHT]
+        # comment
+        ; comment
+        name = value
+        ChangeMe
\ No newline at end of file
diff --git a/t/t4018/gitconfig-section-noindent b/t/t4018/gitconfig-section-noindent
new file mode 100644
index 0000000000..75a401b24b
--- /dev/null
+++ b/t/t4018/gitconfig-section-noindent
@@ -0,0 +1,5 @@ 
+[RIGHT]
+# comment
+; comment
+name = value
+ChangeMe
\ No newline at end of file
diff --git a/t/t4018/gitconfig-subsection b/t/t4018/gitconfig-subsection
new file mode 100644
index 0000000000..06243db626
--- /dev/null
+++ b/t/t4018/gitconfig-subsection
@@ -0,0 +1,7 @@ 
+[LEFT]
+
+[LEFT "RIGHT"]
+      # comment
+      ; comment
+      name = value
+      ChangeMe
\ No newline at end of file
diff --git a/t/t4018/gitconfig-subsection-noindent b/t/t4018/gitconfig-subsection-noindent
new file mode 100644
index 0000000000..a100b81cf1
--- /dev/null
+++ b/t/t4018/gitconfig-subsection-noindent
@@ -0,0 +1,7 @@ 
+[LEFT]
+
+[LEFT "RIGHT"]
+# comment
+; comment
+name = value
+ChangeMe
\ No newline at end of file