| Message ID | 20b0d8599099a412833af93f85e414fdc495dd76.1568405611.git.bert.wesarg@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4] git-gui: add horizontal scrollbar to commit buffer | expand |
Thanks for the re-roll. Will queue. On 13/09/19 10:16PM, Bert Wesarg wrote: > While the commit message widget has a configurable fixed width, it > nevertheless allowed to write commit messages which exceeded this limit. > Though there is no visual clue, that there is scrolling going on. Now > there is a horizontal scrollbar. > > There seems to be a bug in at least Tcl/Tk up to version 8.6.8, which > does not update the horizontal scrollbar if one removes the whole > content at once. > > Suggested-by: Birger Skogeng Pedersen <birger.sp@gmail.com> > Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com> > --- > git-gui.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/git-gui.sh b/git-gui.sh > index 5bc21b8..ad962d4 100755 > --- a/git-gui.sh > +++ b/git-gui.sh > @@ -3363,10 +3363,16 @@ ttext $ui_comm -background white -foreground black \ > -relief sunken \ > -width $repo_config(gui.commitmsgwidth) -height 9 -wrap none \ > -font font_diff \ > + -xscrollcommand {.vpane.lower.commarea.buffer.frame.sbx set} \ > -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set} > +${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sbx \ > + -orient horizontal \ > + -command [list $ui_comm xview] > ${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sby \ > + -orient vertical \ > -command [list $ui_comm yview] > > +pack .vpane.lower.commarea.buffer.frame.sbx -side bottom -fill x > pack .vpane.lower.commarea.buffer.frame.sby -side right -fill y > pack $ui_comm -side left -fill y > pack .vpane.lower.commarea.buffer.header -side top -fill x > -- > 2.21.0.789.ga095d9d866 >
diff --git a/git-gui.sh b/git-gui.sh index 5bc21b8..ad962d4 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -3363,10 +3363,16 @@ ttext $ui_comm -background white -foreground black \ -relief sunken \ -width $repo_config(gui.commitmsgwidth) -height 9 -wrap none \ -font font_diff \ + -xscrollcommand {.vpane.lower.commarea.buffer.frame.sbx set} \ -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set} +${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sbx \ + -orient horizontal \ + -command [list $ui_comm xview] ${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sby \ + -orient vertical \ -command [list $ui_comm yview] +pack .vpane.lower.commarea.buffer.frame.sbx -side bottom -fill x pack .vpane.lower.commarea.buffer.frame.sby -side right -fill y pack $ui_comm -side left -fill y pack .vpane.lower.commarea.buffer.header -side top -fill x
While the commit message widget has a configurable fixed width, it nevertheless allowed to write commit messages which exceeded this limit. Though there is no visual clue, that there is scrolling going on. Now there is a horizontal scrollbar. There seems to be a bug in at least Tcl/Tk up to version 8.6.8, which does not update the horizontal scrollbar if one removes the whole content at once. Suggested-by: Birger Skogeng Pedersen <birger.sp@gmail.com> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com> --- git-gui.sh | 6 ++++++ 1 file changed, 6 insertions(+)