| Message ID | 48752d8b164bc0b11f4d82016415811a0b2bf08b.1588695295.git.congdanhqx@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Provide option to opt in/out GitHub Actions | expand |
On Tue, May 05, 2020 at 11:26:39PM +0700, Đoàn Trần Công Danh wrote: > From 889cacb689 (ci: configure GitHub Actions for CI/PR, 2020-04-11), > GitHub Actions was introduced as an alternative CI system for Git > project. > > Let's advertise it to Git's contributors to help them test Git on > various platforms before submitting to Git. I think this makes sense. Two things: > +Alternately, you can use GitHub Actions (which supports testing your changes > +on Linux, macOS, and Windows) by pushing into a branch in your fork > +or opening a GitHub's Pull Request against > +https://github.com/git/git.git or a fork of that repository. Probably "GitHub Pull Request" would be more idiomatic English. Do people need to enable Actions on their forks for the branch push to work? I didn't need to for my fork of git/git, but I'm not sure if that's because I was playing with Actions months ago and forgot, or if having actions enabled on the parent repo makes it work. When I made a new repository that was not connected, I had to explicitly enable Actions on the site before it would run the workflow file. -Peff
On 2020-05-05 12:47:40-0400, Jeff King <peff@peff.net> wrote: > On Tue, May 05, 2020 at 11:26:39PM +0700, Đoàn Trần Công Danh wrote: > > > From 889cacb689 (ci: configure GitHub Actions for CI/PR, 2020-04-11), > > GitHub Actions was introduced as an alternative CI system for Git > > project. > > > > Let's advertise it to Git's contributors to help them test Git on > > various platforms before submitting to Git. > > I think this makes sense. Two things: > > > +Alternately, you can use GitHub Actions (which supports testing your changes > > +on Linux, macOS, and Windows) by pushing into a branch in your fork > > +or opening a GitHub's Pull Request against > > +https://github.com/git/git.git or a fork of that repository. > > Probably "GitHub Pull Request" would be more idiomatic English. I guess you're right. Well, I'm not native English speaker. I was thinking, this kind of Pull Request is specific to GitHub, and it's different from git-request-pull(1), So, I use "'s" :) > Do people need to enable Actions on their forks for the branch push to > work? I didn't need to for my fork of git/git, but I'm not sure if that's > because I was playing with Actions months ago and forgot, or if having > actions enabled on the parent repo makes it work. It's a long time from the first time I tinker with GitHub Actions, I couldn't recall if I need to enable it explicitly. I look into GitHub support pages[1] and GitHub tells me that GitHub Actions is enabled by default for everyone, and every repo. We need to disable GitHub Actions explicitly, if we don't want it. > When I made a new repository that was not connected, I had to explicitly > enable Actions on the site before it would run the workflow file. It seems like GitHub Actions will be triggered automatically if GitHub finds any files in "$TOPDIR/.github/workflows/*.yml" [1]: https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#disabling-or-limiting-github-actions-for-your-repository-or-organization
On Tue, May 05, 2020 at 11:59:33PM +0700, Đoàn Trần Công Danh wrote: > > > +Alternately, you can use GitHub Actions (which supports testing your changes > > > +on Linux, macOS, and Windows) by pushing into a branch in your fork > > > +or opening a GitHub's Pull Request against > > > +https://github.com/git/git.git or a fork of that repository. > > > > Probably "GitHub Pull Request" would be more idiomatic English. > > I guess you're right. > > Well, I'm not native English speaker. > I was thinking, this kind of Pull Request is specific to GitHub, > and it's different from git-request-pull(1), So, I use "'s" :) Using the possessive "'s" would imply you're talking about GitHub's feature itself. But you're talking about "a" pull request, so I think you want to just GitHub as an adjective, which would not generally be possessive. English is quirky. :) > > When I made a new repository that was not connected, I had to explicitly > > enable Actions on the site before it would run the workflow file. > > It seems like GitHub Actions will be triggered automatically if GitHub > finds any files in "$TOPDIR/.github/workflows/*.yml" It definitely wasn't for me. Try creating a new repo and going to the "Actions" tab. I get a "Get Started with GitHub Actions" page. If I push up a copy of git.git's master, then I get "Workflows aren't being run in this repository" with a big green button to enable. I'm just not sure if that happens for people who fork git/git instead of making a new repo. I'm reluctant to delete and remake my fork, but I guess it wouldn't be too hard to re-create. I think it's OK to leave it out for now. Even if this is how it works for a fork, it's not hard to discover what to do if you click the Actions tab. -Peff
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 4515cab519..8686318550 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -78,6 +78,11 @@ on open source projects), you can use their Travis CI integration to test your changes on Linux, Mac (and hopefully soon Windows). See GitHub-Travis CI hints section for details. +Alternately, you can use GitHub Actions (which supports testing your changes +on Linux, macOS, and Windows) by pushing into a branch in your fork +or opening a GitHub's Pull Request against +https://github.com/git/git.git or a fork of that repository. + Do not forget to update the documentation to describe the updated behavior and make sure that the resulting documentation set formats well (try the Documentation/doc-diff script).
From 889cacb689 (ci: configure GitHub Actions for CI/PR, 2020-04-11), GitHub Actions was introduced as an alternative CI system for Git project. Let's advertise it to Git's contributors to help them test Git on various platforms before submitting to Git. Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> --- Documentation/SubmittingPatches | 5 +++++ 1 file changed, 5 insertions(+)