From patchwork Fri Apr 12 19:51:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Tan X-Patchwork-Id: 10899081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AC4A21800 for ; Fri, 12 Apr 2019 19:51:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F04628F2F for ; Fri, 12 Apr 2019 19:51:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8394328F35; Fri, 12 Apr 2019 19:51:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2D0A28F2F for ; Fri, 12 Apr 2019 19:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbfDLTvd (ORCPT ); Fri, 12 Apr 2019 15:51:33 -0400 Received: from mail-yw1-f74.google.com ([209.85.161.74]:38510 "EHLO mail-yw1-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbfDLTvb (ORCPT ); Fri, 12 Apr 2019 15:51:31 -0400 Received: by mail-yw1-f74.google.com with SMTP id i203so7754445ywa.5 for ; Fri, 12 Apr 2019 12:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=YzjnCYhoqUX4sZpUu0U/9KO2xhZTR6i6LWSZV+BVRfc=; b=VSjmb/LGIlIb4IwozypbC5fQ98lL42Bk9moV9R36Jfx+H3Fq+yM4Ny/cG48Ks6KyIm eQEpYZJ8xD1s/5tD0N+fnh4dK9LDPMmqaoX/pXfvpGwIqp13MxeMlEpb9B5bAVSS0E6B LxQ98lJ8pCWNnxINkdV0CLl7uSqMqxCwH4OKupH179soGX+2C6eKoMtXnYx4rnwhf8ZW 5C5lgdDS5KIp6MxbEBsjj7bWe0LxPH0rup6HaT73InDyidybvDSSQe27KklHjcAoAIUZ zoRrNHf5lfNpVrXKN6W1vGnAbUpcAWvxW7rGRJpsLpK55/MihqwOEFedrjsXwV1DwaNh Z3HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=YzjnCYhoqUX4sZpUu0U/9KO2xhZTR6i6LWSZV+BVRfc=; b=U7CAd5u95bZHqgtIxWj4j0UYaBJil2IQ8srUgtxVWEXqoKFmlFk5qCO3PzDK+FjpV5 gegMzO6FtIKY5POcw54iocQCaF5o3++69XrW2o+QzZu8WWukUckRBUl8Wa7jxOFm/WQE igWXNsdz/p6wr6jfzcQnXae223VKQTjYXTrkZCsG6X60VmpVPlJXK0C2kvASO8Pk7pPb QHUgYqemo4yZHv6EL+y7LqMbK9s+SV68Zy0r6hDD+LpTFhDNSLbZbYnfIQJtr+36cn5G 4sNUYuSmljVMK7ReUBHA/Xd2PlLOyHyMXuFjTdHh4BiyVsQl3/+VyQNVfFHrfkO6cDYS c0Og== X-Gm-Message-State: APjAAAW8dEl7WGHzI8mm/n89TSVsSANK+f2xA5qpW5Jw7hrH6cwUaVg8 EaPGFmxTeCWSjxApuLxm7mdcBvlLvvtkowAmgxYm9llDGulvRIwsjqSlSKI7Ffs+5Hah2Xrmu8V ALmModay+WXX23wm7+35n2pUb7ufI2pnuSOvaF3G1tKevYqyeThW1daqylU6sp4WwekrZTY6oIF 3W X-Google-Smtp-Source: APXvYqxkfWDW8U5HXEg5Q8/Awj4QuTRe6NKNIOi9ntKybONBkGVLEtn6yi4Tj8Nw+8XoiHenDdwhkx88CtQnN6HJLCMj X-Received: by 2002:a25:6cc6:: with SMTP id h189mr10935629ybc.13.1555098690779; Fri, 12 Apr 2019 12:51:30 -0700 (PDT) Date: Fri, 12 Apr 2019 12:51:22 -0700 In-Reply-To: Message-Id: <48bdd462c4e6f609827f4970ee76316e3b54b400.1555098572.git.jonathantanmy@google.com> Mime-Version: 1.0 References: <20190405204413.93900-1-jonathantanmy@google.com> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog Subject: [PATCH v4 2/2] clone: send server options when using protocol v2 From: Jonathan Tan To: git@vger.kernel.org Cc: Jonathan Tan , Jonathan Nieder , Junio C Hamano Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 5e3548ef16 ("fetch: send server options when using protocol v2", 2018-04-24) taught "fetch" the ability to send server options when using protocol v2, but not "clone". This ability is triggered by "-o" or "--server-option". Teach "clone" the same ability, except that because "clone" already has "-o" for another parameter, teach "clone" only to receive "--server-option". Explain in the documentation, both for clone and for fetch, that server handling of server options are server-specific. This is similar to receive-pack's handling of push options - currently, they are just sent to hooks to interpret as they see fit. Signed-off-by: Jonathan Tan Reviewed-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- Documentation/fetch-options.txt | 3 ++- Documentation/git-clone.txt | 8 ++++++++ builtin/clone.c | 6 ++++++ t/t5702-protocol-v2.sh | 22 ++++++++++++++++++++++ 4 files changed, 38 insertions(+), 1 deletion(-) diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt index fa0a3151b3..91c47752ec 100644 --- a/Documentation/fetch-options.txt +++ b/Documentation/fetch-options.txt @@ -216,7 +216,8 @@ endif::git-pull[] --server-option=