From patchwork Sat Apr 2 16:10:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jean-No=C3=ABl_Avila?= X-Patchwork-Id: 12799379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FDCC433EF for ; Sat, 2 Apr 2022 16:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357806AbiDBQNi (ORCPT ); Sat, 2 Apr 2022 12:13:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357791AbiDBQMw (ORCPT ); Sat, 2 Apr 2022 12:12:52 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D47D960AA5 for ; Sat, 2 Apr 2022 09:10:57 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id f6-20020a1c3806000000b0038e4a0fc5easo3110183wma.3 for ; Sat, 02 Apr 2022 09:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:in-reply-to:references:from:date:subject:mime-version :content-transfer-encoding:fcc:to:cc; bh=6DaPrcjxVMvvzmMZmrPrzIEb2xqD07AEYgYG0ai+j0Y=; b=OZpz/BU80G7uOWaq4DaxExzVk21wSxGJlIciVujli4on/+67kGWjZTVLBdUZJQvQaV 8eUL8yw9Ji+XNqeHkzUh4xJV3U+QTOfn/T0wPTbJrXhX2YrET846j+sm3GmWAjxlvk8u izPUf4KlvafhcLfsSPd1KvlVc1s0W4xFyKtByrO2rwDldvF/RvZdLd6bs1NRWvVcgfwJ aYw1FksOvc/VyYwe7vYb2vXmhjUCNE/559pDgjNKydvQF7PCaN9yBs0j6Pt/Cb/9XvEN uGZiDfkbaq84LWUfjpq7EnuZJdVvfMoVe0CxguCBbWohOqmmtqlZ/SzriMWQClTfpSBs 39sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:mime-version:content-transfer-encoding:fcc:to:cc; bh=6DaPrcjxVMvvzmMZmrPrzIEb2xqD07AEYgYG0ai+j0Y=; b=o/Ww9N6SwmTxn5ZS4+gEHeJSMwzkQeqMsRKgJuYw9LhV3+UAnO6PE7NaMfBghFXvOD 5HJRDd6jI7SCzhUBlwFTcKnoGj+JB8WWeOHb0t7E9gxZYiS5dxwpqZvvgaiPC3vPXMRf a8AH6EAHTflaEFRSbsttzXyLicJE1CbslYuJV84pPnyeCr8zWf02XCbJMbPWgYzgJon7 kHCSkWytKQiOf3ts/b06H9BSjW1tUhGXRR1j2K5+hBhOsVpw14YR38K0cOmK6UwbOzYF oNGQmYscfxgKtL61phsj8Efl+fIKrbuU1H+BYpOJF3OrE0SG+tVQUIddRuRefODTwZ3p E5Og== X-Gm-Message-State: AOAM532V96lHFBMWo5ZYdIs33GSWcfmkzau0OuL62fYHCnToX/m2onnP TyJ0pzJA01eTa/xOalOyXxVJV1ECyJA= X-Google-Smtp-Source: ABdhPJw39/Yf+u0b6n9iEmTimD4NbliuIs08b8sg7eWZcaen+PuMOH33Ic3smSkWtkIZINtxISiQBA== X-Received: by 2002:a1c:f705:0:b0:37d:f2e5:d8ec with SMTP id v5-20020a1cf705000000b0037df2e5d8ecmr13192222wmh.21.1648915855983; Sat, 02 Apr 2022 09:10:55 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id e13-20020a05600c4e4d00b0038e44e316c1sm6777631wmq.6.2022.04.02.09.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 09:10:55 -0700 (PDT) Message-Id: <4bba3e1f6cb9cdc35b0dc8da440e38de256b4d2b.1648915853.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Sat, 02 Apr 2022 16:10:48 +0000 Subject: [PATCH v2 1/6] i18n: factorize generic failure messages MIME-Version: 1.0 Fcc: Sent To: git@vger.kernel.org Cc: Bagas Sanjaya , Johannes Sixt , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , =?utf-8?q?Jean-No=C3=ABl?= Avila , =?utf-8?q?Jean-No?= =?utf-8?q?=C3=ABl_Avila?= Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: =?utf-8?q?Jean-No=C3=ABl_Avila?= From: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= In these message the command or the function that failed should not be translated. So it is simpler to just remove these parts from the message. Signed-off-by: Jean-Noël Avila --- add-patch.c | 4 ++-- builtin/am.c | 2 +- builtin/gc.c | 4 ++-- builtin/merge.c | 6 +++--- builtin/revert.c | 4 ++-- fetch-pack.c | 2 +- remote-curl.c | 2 +- setup.c | 4 ++-- t/t3510-cherry-pick-sequence.sh | 8 ++++---- t/t6436-merge-overwrite.sh | 2 +- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/add-patch.c b/add-patch.c index 55d719f7845..8c9e81ec78e 100644 --- a/add-patch.c +++ b/add-patch.c @@ -1181,7 +1181,7 @@ static int run_apply_check(struct add_p_state *s, "apply", "--check", NULL); strvec_pushv(&cp.args, s->mode->apply_check_args); if (pipe_command(&cp, s->buf.buf, s->buf.len, NULL, 0, NULL, 0)) - return error(_("'git apply --cached' failed")); + return error(_("the command '%s' failed"), "git apply --cached"); return 0; } @@ -1683,7 +1683,7 @@ soft_increment: strvec_pushv(&cp.args, s->mode->apply_args); if (pipe_command(&cp, s->buf.buf, s->buf.len, NULL, 0, NULL, 0)) - error(_("'git apply' failed")); + error(_("the command '%s' failed"), "git apply"); } if (repo_read_index(s->s.r) >= 0) repo_refresh_and_write_index(s->s.r, REFRESH_QUIET, 0, diff --git a/builtin/am.c b/builtin/am.c index 0f4111bafa0..a0a57049510 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -586,7 +586,7 @@ static int is_mail(FILE *fp) int ret = 1; if (fseek(fp, 0L, SEEK_SET)) - die_errno(_("fseek failed")); + die_errno(_("the function '%s' failed"), "fseek"); if (regcomp(®ex, header_regex, REG_NOSUB | REG_EXTENDED)) die("invalid pattern: %s", header_regex); diff --git a/builtin/gc.c b/builtin/gc.c index ffaf0daf5d9..c062d7bceeb 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -1104,7 +1104,7 @@ static int multi_pack_index_expire(struct maintenance_run_opts *opts) strvec_push(&child.args, "--no-progress"); if (run_command(&child)) - return error(_("'git multi-pack-index expire' failed")); + return error(_("the command '%s' failed"), "git multi-pack-index expire"); return 0; } @@ -1163,7 +1163,7 @@ static int multi_pack_index_repack(struct maintenance_run_opts *opts) (uintmax_t)get_auto_pack_size()); if (run_command(&child)) - return error(_("'git multi-pack-index repack' failed")); + return error(_("the command '%s' failed"), "git multi-pack-index repack"); return 0; } diff --git a/builtin/merge.c b/builtin/merge.c index f178f5a3ee1..78468ff43a4 100644 --- a/builtin/merge.c +++ b/builtin/merge.c @@ -325,7 +325,7 @@ static int save_state(struct object_id *stash) close(cp.out); if (finish_command(&cp) || len < 0) - die(_("stash failed")); + die(_("the command '%s' failed"), "stash"); else if (!len) /* no changes */ goto out; strbuf_setlen(&buffer, buffer.len-1); @@ -352,7 +352,7 @@ static void read_empty(const struct object_id *oid, int verbose) args[i] = NULL; if (run_command_v_opt(args, RUN_GIT_CMD)) - die(_("read-tree failed")); + die(_("the command '%s' failed"), "read-tree"); } static void reset_hard(const struct object_id *oid, int verbose) @@ -369,7 +369,7 @@ static void reset_hard(const struct object_id *oid, int verbose) args[i] = NULL; if (run_command_v_opt(args, RUN_GIT_CMD)) - die(_("read-tree failed")); + die(_("the command '%s' failed"), "read-tree"); } static void restore_state(const struct object_id *head, diff --git a/builtin/revert.c b/builtin/revert.c index 51776abea63..d293036e790 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -238,7 +238,7 @@ int cmd_revert(int argc, const char **argv, const char *prefix) sequencer_init_config(&opts); res = run_sequencer(argc, argv, &opts); if (res < 0) - die(_("revert failed")); + die(_("the command '%s' failed"), "revert"); return res; } @@ -251,6 +251,6 @@ int cmd_cherry_pick(int argc, const char **argv, const char *prefix) sequencer_init_config(&opts); res = run_sequencer(argc, argv, &opts); if (res < 0) - die(_("cherry-pick failed")); + die(_("the command '%s' failed"), "cherry-pick"); return res; } diff --git a/fetch-pack.c b/fetch-pack.c index 87657907e78..2e6795cd439 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -989,7 +989,7 @@ static int get_pack(struct fetch_pack_args *args, args->check_self_contained_and_connected && ret == 0; else - die(_("%s failed"), cmd_name); + die(_("the command '%s' failed"), cmd_name); if (use_sideband && finish_async(&demux)) die(_("error in sideband demultiplexer")); diff --git a/remote-curl.c b/remote-curl.c index ff44f41011e..8393f56652b 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -1287,7 +1287,7 @@ static int push_dav(int nr_spec, const char **specs) strvec_push(&child.args, specs[i]); if (run_command(&child)) - die(_("git-http-push failed")); + die(_("the command '%s' failed"), "git-http-push"); return 0; } diff --git a/setup.c b/setup.c index 04ce33cdcd4..30a4b81257d 100644 --- a/setup.c +++ b/setup.c @@ -1506,12 +1506,12 @@ int daemonize(void) case 0: break; case -1: - die_errno(_("fork failed")); + die_errno(_("the function '%s' failed"), "fork"); default: exit(0); } if (setsid() == -1) - die_errno(_("setsid failed")); + die_errno(_("the function '%s' failed"), "setsid"); close(0); close(1); close(2); diff --git a/t/t3510-cherry-pick-sequence.sh b/t/t3510-cherry-pick-sequence.sh index 3b0fa66c33d..141d217dc3f 100755 --- a/t/t3510-cherry-pick-sequence.sh +++ b/t/t3510-cherry-pick-sequence.sh @@ -193,7 +193,7 @@ test_expect_success 'check advice when we move HEAD by committing' ' error: there is nothing to skip hint: have you committed already? hint: try "git cherry-pick --continue" - fatal: cherry-pick failed + fatal: the command '\''cherry-pick'\'' failed EOF test_must_fail git cherry-pick base..yetanotherpick && echo c >foo && @@ -208,7 +208,7 @@ test_expect_success 'selectively advise --skip while launching another sequence' cat >expect <<-EOF && error: cherry-pick is already in progress hint: try "git cherry-pick (--continue | --skip | --abort | --quit)" - fatal: cherry-pick failed + fatal: the command '\''cherry-pick'\'' failed EOF test_must_fail git cherry-pick picked..yetanotherpick && test_must_fail git cherry-pick picked..yetanotherpick 2>advice && @@ -216,7 +216,7 @@ test_expect_success 'selectively advise --skip while launching another sequence' cat >expect <<-EOF && error: cherry-pick is already in progress hint: try "git cherry-pick (--continue | --abort | --quit)" - fatal: cherry-pick failed + fatal: the command '\''cherry-pick'\'' failed EOF git reset --merge && test_must_fail git cherry-pick picked..yetanotherpick 2>advice && @@ -227,7 +227,7 @@ test_expect_success 'allow skipping commit but not abort for a new history' ' pristine_detach initial && cat >expect <<-EOF && error: cannot abort from a branch yet to be born - fatal: cherry-pick failed + fatal: the command '\''cherry-pick'\'' failed EOF git checkout --orphan new_disconnected && git reset --hard && diff --git a/t/t6436-merge-overwrite.sh b/t/t6436-merge-overwrite.sh index c0b7bd7c3fe..c714ac2cbc5 100755 --- a/t/t6436-merge-overwrite.sh +++ b/t/t6436-merge-overwrite.sh @@ -166,7 +166,7 @@ test_expect_success 'will not be confused by symlink in leading path' ' cat >expect <<\EOF error: Untracked working tree file 'c0.c' would be overwritten by merge. -fatal: read-tree failed +fatal: the command 'read-tree' failed EOF test_expect_success 'will not overwrite untracked file on unborn branch' '