diff mbox series

[v3,8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email

Message ID 4fcab0d3319fa47c2f4126139ca636d6848e9e3d.1712699815.git.gitgitgadget@gmail.com (mailing list archive)
State Superseded
Headers show
Series docs: recommend using contrib/contacts/git-contacts | expand

Commit Message

Linus Arver April 9, 2024, 9:56 p.m. UTC
From: Linus Arver <linusa@google.com>

Signed-off-by: Linus Arver <linusa@google.com>
---
 Documentation/SubmittingPatches | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Kipras Melnikovas April 11, 2024, 12:19 a.m. UTC | #1
I don't think `git contacts` is available by default?

...
$ git contacts
git: 'contacts' is not a git command. See 'git --help'.
...

...
$ git send-email --to=kipras@kipras.org --cc-cmd='git contacts' 0001-TEMP.patch
0001-TEMP.patch
git: 'contacts' is not a git command. See 'git --help'.
(cc-cmd) failed to close pipe to 'git contacts' at /opt/homebrew/opt/git/libexec/git-core/git-send-email line 2021.
...
Linus Arver April 11, 2024, 9:03 p.m. UTC | #2
Kipras Melnikovas <kipras@kipras.org> writes:

> I don't think `git contacts` is available by default?

Correct. It's a Perl script that lives under contrib/ in the git repo
(it's not part of the core set of default Git subcommands that the "git"
binary is built with). On Ubuntu it lives under
/usr/share/doc/git/contrib/contacts/git-contacts [1].

[1] https://packages.ubuntu.com/focal/amd64/git/filelist

I could add a blurb about this to avoid confusion. Will update.

> ...
> $ git contacts
> git: 'contacts' is not a git command. See 'git --help'.
> ...
>
> ...
> $ git send-email --to=kipras@kipras.org --cc-cmd='git contacts' 0001-TEMP.patch
> 0001-TEMP.patch
> git: 'contacts' is not a git command. See 'git --help'.
> (cc-cmd) failed to close pipe to 'git contacts' at /opt/homebrew/opt/git/libexec/git-core/git-send-email line 2021.
> ...
Kipras Melnikovas April 12, 2024, 8:48 a.m. UTC | #3
>> I don't think `git contacts` is available by default?

> I could add a blurb about this to avoid confusion. Will update.

Thanks, v4 looks good to me.
diff mbox series

Patch

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index bafb1ee0157..57953898cee 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -413,6 +413,13 @@  trial merges of your topic to `next` and `seen`, you may have noticed
 work by others conflicting with your changes.  There is a good possibility
 that these people may know the area you are touching well.
 
+If you are using `send-email`, you can feed it the output of `git contacts` like
+this:
+
+....
+	git send-email --cc-cmd='git contacts' feature/*.patch
+....
+
 :current-maintainer: footnote:[The current maintainer: gitster@pobox.com]
 :git-ml: footnote:[The mailing list: git@vger.kernel.org]