| Message ID | 87afcee830caab2782ce693c1f961df6fea6e7b5.1698314128.git.ps@pks.im (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 53921d5f8e63eb98cb306ea0b58f76a07bbaf36b |
| Headers | show |
| Series | show-ref: introduce mode to check for ref existence | expand |
On Thu, Oct 26, 2023 at 11:56:33AM +0200, Patrick Steinhardt wrote: > When passing patterns to `git show-ref` we have some code that will > cause us to die if `verify && !quiet` is true. But because `verify` > indicates a different subcommand of git-show-ref(1) that causes us to > execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the > condition cannot ever be true. > > Let's remove this dead code. Makes sense. Let's read on... Thanks, Taylor
diff --git a/builtin/show-ref.c b/builtin/show-ref.c index e55c38af478..f95418d3d16 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -183,11 +183,8 @@ static int cmd_show_ref__patterns(const char **patterns) } else { for_each_ref(show_ref, &show_ref_data); } - if (!found_match) { - if (verify && !quiet) - die("No match"); + if (!found_match) return 1; - } return 0; }
When passing patterns to `git show-ref` we have some code that will cause us to die if `verify && !quiet` is true. But because `verify` indicates a different subcommand of git-show-ref(1) that causes us to execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the condition cannot ever be true. Let's remove this dead code. Signed-off-by: Patrick Steinhardt <ps@pks.im> --- builtin/show-ref.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)