| Message ID | 9e5a8625cab217bd6aaba68da081bc801354b903.1602059508.git.liu.denton@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fcedb379fd1842cf943a05a331be862ad8d2d919 |
| Headers | show |
| Series | compat/mingw.h: drop extern from function declaration | expand |
Hi Denton, On Wed, 7 Oct 2020, Denton Liu wrote: > In 554544276a (*.[ch]: remove extern from function declarations using > spatch, 2019-04-29), `extern` on function declarations were declared to > be redundant and thus removed from the codebase. An `extern` was > accidentally reintroduced in 08809c09aa (mingw: add a helper function to > attach GDB to the current process, 2020-02-13). > > Remove this spurious `extern`. ACK! Thanks, Dscho > > Signed-off-by: Denton Liu <liu.denton@gmail.com> > --- > > Notes: > This patch is based on 554544276a, formerly 'js/mingw-open-in-gdb'. > > compat/mingw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/compat/mingw.h b/compat/mingw.h > index 88c07c4520..5c34547539 100644 > --- a/compat/mingw.h > +++ b/compat/mingw.h > @@ -599,7 +599,7 @@ int main(int argc, const char **argv); > * Call this function to open a new MinTTY (this assumes you are in Git for > * Windows' SDK) with a GDB that attaches to the current process right away. > */ > -extern void open_in_gdb(void); > +void open_in_gdb(void); > > /* > * Used by Pthread API implementation for Windows > -- > 2.28.0.942.g77c4c6094c > >
diff --git a/compat/mingw.h b/compat/mingw.h index 88c07c4520..5c34547539 100644 --- a/compat/mingw.h +++ b/compat/mingw.h @@ -599,7 +599,7 @@ int main(int argc, const char **argv); * Call this function to open a new MinTTY (this assumes you are in Git for * Windows' SDK) with a GDB that attaches to the current process right away. */ -extern void open_in_gdb(void); +void open_in_gdb(void); /* * Used by Pthread API implementation for Windows
In 554544276a (*.[ch]: remove extern from function declarations using spatch, 2019-04-29), `extern` on function declarations were declared to be redundant and thus removed from the codebase. An `extern` was accidentally reintroduced in 08809c09aa (mingw: add a helper function to attach GDB to the current process, 2020-02-13). Remove this spurious `extern`. Signed-off-by: Denton Liu <liu.denton@gmail.com> --- Notes: This patch is based on 554544276a, formerly 'js/mingw-open-in-gdb'. compat/mingw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)