diff mbox series

[19/20] commit-graph.c: prevent overflow in `write_commit_graph()`

Message ID 9f66e1e6eeb7386010d7387c37766260bf38b338.1689205042.git.me@ttaylorr.com (mailing list archive)
State Accepted
Commit 588af1bfd3c810e02df1d8adc37e9c43a7f97920
Headers show
Series guard object lookups against 32-bit overflow | expand

Commit Message

Taylor Blau July 12, 2023, 11:38 p.m. UTC 
In a similar spirit as previous commits, ensure that we don't overflow
when trying to read an existing OID while writing a new commit-graph.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
 commit-graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/commit-graph.c b/commit-graph.c
index c679d1d633..20d9296c8b 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -2453,7 +2453,7 @@  int write_commit_graph(struct object_directory *odb,
 		struct commit_graph *g = ctx->r->objects->commit_graph;
 		for (i = 0; i < g->num_commits; i++) {
 			struct object_id oid;
-			oidread(&oid, g->chunk_oid_lookup + g->hash_len * i);
+			oidread(&oid, g->chunk_oid_lookup + st_mult(g->hash_len, i));
 			oid_array_append(&ctx->oids, &oid);
 		}
 	}