diff mbox series

[19/21] userformat_want_item(): mark unused parameter

Message ID	Y/hbr8J0vxKYnd+/@coredump.intra.peff.net (mailing list archive)
State	Accepted
Commit	1bff855419b0cb338e7ef53b77f99207704bf63e
Headers	show Return-Path: <git-owner@vger.kernel.org> Date: Fri, 24 Feb 2023 01:39:43 -0500 From: Jeff King <peff@peff.net> To: git@vger.kernel.org Subject: [PATCH 19/21] userformat_want_item(): mark unused parameter Message-ID: <Y/hbr8J0vxKYnd+/@coredump.intra.peff.net> References: <Y/habYJxDRJQg/kJ@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <Y/habYJxDRJQg/kJ@coredump.intra.peff.net> Precedence: bulk
Series	more -Wunused-parameter fixes \| expand [0/21] more -Wunused-parameter fixes [01/21] ref-filter: drop unused atom parameter from get_worktree_path() [02/21] ls-refs: drop config caching [03/21] serve: use repository pointer to get config [04/21] serve: mark unused parameters in virtual functions [05/21] object-name: mark unused parameters in disambiguate callbacks [06/21] http-backend: mark argc/argv unused [07/21] http-backend: mark unused parameters in virtual functions [08/21] ref-filter: mark unused callback parameters [09/21] mark "pointless" data pointers in callbacks [10/21] run-command: mark error routine parameters as unused [11/21] mark unused parameters in signal handlers [12/21] list-objects: mark unused callback parameters [13/21] for_each_object: mark unused callback parameters [14/21] prio-queue: mark unused parameters in comparison functions [15/21] notes: mark unused callback parameters [16/21] fetch-pack: mark unused parameter in callback function [17/21] rewrite_parents(): mark unused callback parameter [18/21] for_each_commit_graft(): mark unused callback parameter [19/21] userformat_want_item(): mark unused parameter [20/21] run_processes_parallel: mark unused callback parameters [21/21] help: mark unused parameter in git_unknown_cmd_config()

Commit Message

Jeff King Feb. 24, 2023, 6:39 a.m. UTC

This function is used as a callback to strbuf_expand(), so it must
conform to the correct interface. But naturally it doesn't need to touch
its "sb" parameter, since it is only examining the placeholder string,
and not actually writing any output. So mark the unused parameter to
silence -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
---
 pretty.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/pretty.c b/pretty.c
index 1e1e21878c..2e47292407 100644
--- a/pretty.c
+++ b/pretty.c
@@ -1857,7 +1857,8 @@  static size_t format_commit_item(struct strbuf *sb, /* in UTF-8 */
 	return consumed + 1;
 }
 
-static size_t userformat_want_item(struct strbuf *sb, const char *placeholder,
+static size_t userformat_want_item(struct strbuf *sb UNUSED,
+				   const char *placeholder,
 				   void *context)
 {
 	struct userformat_want *w = context;