p5326: create tag needed for shared tests

Commit Message

René Scharfe Oct. 2, 2021, 5:22 p.m. UTC

p5326 fails with the following error:

   perf 8 - rev-list with tag negated via --not --all (objects):
   running:
   		git rev-list perf-tag --not --all --use-bitmap-index --objects >/dev/null

   fatal: ambiguous argument 'perf-tag': unknown revision or path not in the working tree.
   Use '--' to separate paths from revisions, like this:
   'git <command> [<revision>...] -- [<file>...]'

Reason: 540cdc11ad (pack-bitmap: avoid traversal of objects referenced
by uninteresting tag, 2021-03-22) added two tests and created a tag as a
prerequisite for them.  9387fbd646 (p5310: extract full and partial
bitmap tests, 2021-08-31) moved the two tests (and others) to
t/perf/lib-bitmap.sh, but not the code for creating the tag.  2d59597333
(p5326: perf tests for MIDX bitmaps, 2021-08-31) used this library, but
didn't create the tag.

Create the neccesary tag in p5326 using the code from p5310.

Signed-off-by: René Scharfe <[e-mail]>
---
 t/perf/p5326-multi-pack-bitmaps.sh | 6 ++++++
 1 file changed, 6 insertions(+)

--
2.33.0

Comments

Taylor Blau Oct. 3, 2021, 4:58 a.m. UTC | #1

Hi René,

On Sat, Oct 02, 2021 at 07:22:35PM +0200, René Scharfe wrote:
> p5326 fails with the following error:

Thanks for noticing; this is indeed my error, and your reasoning is
accurate.

This came up during my series to propagate namehash values into MIDX
bitmaps here:

    https://lore.kernel.org/git/[e-mail]/

and is in next as 2082224f17 (p5326: create missing 'perf-tag' tag,
2021-09-14).

Thanks,
Taylor

Patch

diff --git a/t/perf/p5326-multi-pack-bitmaps.sh b/t/perf/p5326-multi-pack-bitmaps.sh
index 5845109ac7..51b5636259 100755
--- a/t/perf/p5326-multi-pack-bitmaps.sh
+++ b/t/perf/p5326-multi-pack-bitmaps.sh
@@ -10,6 +10,12 @@  test_expect_success 'enable multi-pack index' '
 	git config core.multiPackIndex true
 '

+# we need to create the tag up front such that it is covered by the repack and
+# thus by generated bitmaps.
+test_expect_success 'create tags' '
+	git tag --message="tag pointing to HEAD" perf-tag HEAD
+'
+
 test_perf 'setup multi-pack index' '
 	git repack -ad &&
 	git multi-pack-index write --bitmap