From patchwork Mon Apr 19 11:37:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han-Wen Nienhuys X-Patchwork-Id: 12211635 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB197C433ED for ; Mon, 19 Apr 2021 11:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86DD761221 for ; Mon, 19 Apr 2021 11:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238742AbhDSLlc (ORCPT ); Mon, 19 Apr 2021 07:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238762AbhDSLiw (ORCPT ); Mon, 19 Apr 2021 07:38:52 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 190BDC061358 for ; Mon, 19 Apr 2021 04:38:18 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id y204so16598136wmg.2 for ; Mon, 19 Apr 2021 04:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=HmosySL/m4efi8WDhbk+zW/BXfRdB05UHELJfNh7CYE=; b=jYXDyf4/OqGgwiG+0P8lBmVSlLaMbU6SccdkO77+ZOY+CpQ7TkW3ZcAnKqPXhRwyFw CJuElNdbob0Z13gKnLjzqp3W51GTPxCUFbP3NFdjSWHFVXrSW/nnKXBLJhS0LtsyITGT GDCn40d/OXqiZHojlDjkfYBK0atlfMI/Gv+Kj6R2AcSSx820AUucKd6M54lHtc4FoX56 0sQGUv0eXNu0pBG5+WviY0xNCgfkdui97ktHFxwNhusIYkwMAEm40f5dsFA0jHNM4ySO JZ41gvxB+FnINPwc7tefM/fJ9cGy6HG1709W/e4NPHF5LkLUI9t8myK18yKvd0qnBdTv 14TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=HmosySL/m4efi8WDhbk+zW/BXfRdB05UHELJfNh7CYE=; b=dee4EAKnBZ7o/VT7Zmj1dAeNvJ67yDWRIXF+hZQnyy+B91adL7EKMDtqW/bzfi0JnH cWXaPxYP4Ia39lNXSlAn/PMPu85SS26ZXZs3h/I+xCGG8V2WxSbXxv+C9CWcebyHWWRV YHm06/nU7+8bhER22X0HViPJsBCouJxUTen8HZ/+KryiF9UTnSVKffpwvIwMXg5oj8pg X9bOx/sX//P+AH+sWFUYyDv314OXImXMUrOIqvBTNr8iXhGfJCRuPC1tAtPDNQpwBDbZ OgDaQMF+ls3Cc0mnx67oGdSsAXNqEdBBrpU52VM4YJaonhmYJ4r4jZayLZ98aQ7n0F1t +KKg== X-Gm-Message-State: AOAM5336jGcoPcpOCz3ofY/XQMpQbjZSWZnD5AGUYW2ddbh2vcRXVj3l JuLLEkqfxTLykVBeVYYYEeMM+0dOJxg= X-Google-Smtp-Source: ABdhPJwgD4a6UDf4mC4HEl1D+3xD+9C7S6JXyVlmx3s1wMCrWY7BQgUw2jtIGYmgNvrQjQHJgrMgoQ== X-Received: by 2002:a1c:7d4d:: with SMTP id y74mr21349303wmc.31.1618832296918; Mon, 19 Apr 2021 04:38:16 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id s10sm22225951wrt.23.2021.04.19.04.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 04:38:16 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Mon, 19 Apr 2021 11:37:54 +0000 Subject: [PATCH v7 26/28] t1301: document what needs to be done for REFTABLE Fcc: Sent MIME-Version: 1.0 To: git@vger.kernel.org Cc: Han-Wen Nienhuys , Jeff King , Ramsay Jones , Jonathan Nieder , Johannes Schindelin , Jonathan Tan , Josh Steadmon , Emily Shaffer , Patrick Steinhardt , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Felipe Contreras , Derrick Stolee , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Han-Wen Nienhuys g , Han-Wen Nienhuys , Han-Wen Nienhuys Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Han-Wen Nienhuys From: Han-Wen Nienhuys Signed-off-by: Han-Wen Nienhuys --- t/t1301-shared-repo.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh index ac947bff9fcf..194fa54ea3e7 100755 --- a/t/t1301-shared-repo.sh +++ b/t/t1301-shared-repo.sh @@ -22,9 +22,10 @@ test_expect_success 'shared = 0400 (faulty permission u-w)' ' ) ' +# TODO(hanwen): for REFTABLE should inspect group-readable of .git/reftable/ for u in 002 022 do - test_expect_success POSIXPERM "shared=1 does not clear bits preset by umask $u" ' + test_expect_success REFFILES,POSIXPERM "shared=1 does not clear bits preset by umask $u" ' mkdir sub && ( cd sub && umask $u && @@ -114,7 +115,8 @@ test_expect_success POSIXPERM 'info/refs respects umask in unshared repo' ' test_cmp expect actual ' -test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' ' +# For reftable, the check on .git/reftable/ is sufficient. +test_expect_success REFFILES,POSIXPERM 'git reflog expire honors core.sharedRepository' ' umask 077 && git config core.sharedRepository group && git reflog expire --all && @@ -201,7 +203,7 @@ test_expect_success POSIXPERM 're-init respects core.sharedrepository (remote)' test_cmp expect actual ' -test_expect_success POSIXPERM 'template can set core.sharedrepository' ' +test_expect_success REFFILES,POSIXPERM 'template can set core.sharedrepository' ' rm -rf child.git && umask 0022 && git config core.sharedrepository 0666 &&