diff mbox series

t0612: mark as leak-free

Message ID d244fb44-0bd2-4416-b24c-0a93835b75a4@gmail.com (mailing list archive)
State Superseded
Headers show
Series t0612: mark as leak-free | expand

Commit Message

Rubén Justo July 1, 2024, 7:38 p.m. UTC
A quick test tell us that t0612 does not trigger any leak:

    $ make SANITIZE=leak test GIT_TEST_PASSING_SANITIZE_LEAK=check GIT_TEST_SANITIZE_LEAK_LOG=true GIT_TEST_OPTS=-i T=t0612-reftable-jgit-compatibility.sh
    [...]
    *** t0612-reftable-jgit-compatibility.sh ***
    in GIT_TEST_PASSING_SANITIZE_LEAK=check mode, setting --invert-exit-code for TEST_PASSES_SANITIZE_LEAK != true
    ok 1 - CGit repository can be read by JGit
    ok 2 - JGit repository can be read by CGit
    ok 3 - mixed writes from JGit and CGit
    ok 4 - JGit can read multi-level index
    # passed all 4 test(s)
    1..4
    # faking up non-zero exit with --invert-exit-code
    make[2]: *** [Makefile:75: t0612-reftable-jgit-compatibility.sh] Error 1

Let's mark it as leak-free to silence the machinery activated by
`GIT_TEST_PASSING_SANITIZE_LEAK=check`.

Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Rubén Justo <rjusto@gmail.com>
---
 t/t0612-reftable-jgit-compatibility.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Sunshine July 1, 2024, 7:40 p.m. UTC | #1
On Mon, Jul 1, 2024 at 3:38 PM Rubén Justo <rjusto@gmail.com> wrote:
> A quick test tell us that t0612 does not trigger any leak:

s/tell/tells/

>     $ make SANITIZE=leak test GIT_TEST_PASSING_SANITIZE_LEAK=check GIT_TEST_SANITIZE_LEAK_LOG=true GIT_TEST_OPTS=-i T=t0612-reftable-jgit-compatibility.sh
>     [...]
>
> Let's mark it as leak-free to silence the machinery activated by
> `GIT_TEST_PASSING_SANITIZE_LEAK=check`.
>
> Reported-by: Jeff King <peff@peff.net>
> Signed-off-by: Rubén Justo <rjusto@gmail.com>
diff mbox series

Patch

diff --git a/t/t0612-reftable-jgit-compatibility.sh b/t/t0612-reftable-jgit-compatibility.sh
index d0d7e80b49..84922153ab 100755
--- a/t/t0612-reftable-jgit-compatibility.sh
+++ b/t/t0612-reftable-jgit-compatibility.sh
@@ -11,6 +11,7 @@  export GIT_TEST_DEFAULT_REF_FORMAT
 GIT_TEST_SPLIT_INDEX=0
 export GIT_TEST_SPLIT_INDEX
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 if ! test_have_prereq JGIT