[14/27] rm: ensure full index

Message ID	d6816560b32f020d6c38f5e9ad36be532685279c.1615929436.git.gitgitgadget@gmail.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <git-owner@kernel.org> Message-Id: <d6816560b32f020d6c38f5e9ad36be532685279c.1615929436.git.gitgitgadget@gmail.com> In-Reply-To: <pull.906.git.1615929435.gitgitgadget@gmail.com> References: <pull.906.git.1615929435.gitgitgadget@gmail.com> Date: Tue, 16 Mar 2021 21:17:02 +0000 Subject: [PATCH 14/27] rm: ensure full index Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: newren@gmail.com, gitster@pobox.com, Derrick Stolee <derrickstolee@github.com>, Derrick Stolee <dstolee@microsoft.com> Precedence: bulk From: Derrick Stolee <dstolee@microsoft.com>
Series	Sparse Index: API protections \| expand [00/27] Sparse Index: API protections [01/27] *: remove 'const' qualifier for struct index_state [02/27] read-cache: expand on query into sparse-directory entry [03/27] sparse-index: API protection strategy [04/27] cache: move ensure_full_index() to cache.h [05/27] add: ensure full index [06/27] checkout-index: ensure full index [07/27] checkout: ensure full index [08/27] commit: ensure full index [09/27] difftool: ensure full index [10/27] fsck: ensure full index [11/27] grep: ensure full index [12/27] ls-files: ensure full index [13/27] merge-index: ensure full index [14/27] rm: ensure full index [15/27] sparse-checkout: ensure full index [16/27] update-index: ensure full index [17/27] diff-lib: ensure full index [18/27] dir: ensure full index [19/27] entry: ensure full index [20/27] merge-ort: ensure full index [21/27] merge-recursive: ensure full index [22/27] pathspec: ensure full index [23/27] read-cache: ensure full index [24/27] resolve-undo: ensure full index [25/27] revision: ensure full index [26/27] sparse-index: expand_to_path() [27/27] name-hash: use expand_to_path()

Message ID

d6816560b32f020d6c38f5e9ad36be532685279c.1615929436.git.gitgitgadget@gmail.com (mailing list archive)

State

Superseded

Headers

Message-Id: 
 <d6816560b32f020d6c38f5e9ad36be532685279c.1615929436.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.906.git.1615929435.gitgitgadget@gmail.com>
References: <pull.906.git.1615929435.gitgitgadget@gmail.com>
Date: Tue, 16 Mar 2021 21:17:02 +0000
Subject: [PATCH 14/27] rm: ensure full index
Fcc: Sent
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
To: git@vger.kernel.org
Cc: newren@gmail.com, gitster@pobox.com,
        Derrick Stolee <derrickstolee@github.com>,
        Derrick Stolee <dstolee@microsoft.com>
Precedence: bulk
From: Derrick Stolee <dstolee@microsoft.com>

Series

Sparse Index: API protections | expand

Commit Message

Derrick Stolee March 16, 2021, 9:17 p.m. UTC

From: Derrick Stolee <dstolee@microsoft.com>

Before iterating over all cache entries, ensure that a sparse index is
expanded to a full index to avoid unexpected behavior.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
---
 builtin/rm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/builtin/rm.c b/builtin/rm.c
index 4858631e0f02..99125ccb8424 100644
--- a/builtin/rm.c
+++ b/builtin/rm.c
@@ -293,6 +293,7 @@  int cmd_rm(int argc, const char **argv, const char *prefix)
 
 	seen = xcalloc(pathspec.nr, 1);
 
+	ensure_full_index(&the_index);
 	for (i = 0; i < active_nr; i++) {
 		const struct cache_entry *ce = active_cache[i];
 		if (!ce_path_match(&the_index, ce, &pathspec, seen))

[14/27] rm: ensure full index

Commit Message

Patch