From patchwork Thu Apr 11 09:10:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 13625640 Received: from fhigh1-smtp.messagingengine.com (fhigh1-smtp.messagingengine.com [103.168.172.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D25BD1442FA for ; Thu, 11 Apr 2024 09:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.152 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712826655; cv=none; b=YDeISWIXziiQmqtHY/knyyCSTTgDs9fTBZrmaQ0ZWphT37oKMp7x5WPzrzHTaYha34coflORyft0PPprVYMf77yYWLDXp7WUQPrAGtayauhlfuuhKXILeDMbYrRa+MZB3HXBGS6KEGbe+CGfZQHIXwfT3T1Dw8MQ6f423CdSyHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712826655; c=relaxed/simple; bh=zLDMggoUrZWFoaxmQwA8QMbLai7xUZDp7x5xz7iXy2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GoHeO3kZ95vhPE+glJgE79KTKsdut6nMdCcjMOrbqleikHCprGt97fRL2X6RdxTSVj6KKcfqILfnzxp8ZC/M9ou/JUMKMoFVFJg9uV6WkEMLT8OImZSRvRw9xyjyvYHN+V6iZ4nmYdTnAosX0/xRSiCysTG/K6HsPvr0wlckX5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=iUq70cMS; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=nzFwlfhu; arc=none smtp.client-ip=103.168.172.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="iUq70cMS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nzFwlfhu" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id E2D0E1140198; Thu, 11 Apr 2024 05:10:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 11 Apr 2024 05:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1712826650; x=1712913050; bh=tjsVx4nQhx ZS45gfmhMJ/ocdUu92HV7bOMCb/JVjw2E=; b=iUq70cMS7omFvmLbGpRSAEYn4G vWDqkiwCEPsJKIqazu1VwaYO69rL0gTo3MY7MqDrq7ebMP5hbnCR8gZ85DffFRGn eNwqi+JJoLd2kJ4GNZDA/wlOI5WMS3r7yeIwRodCLNUsg2YQ0EtXlgp2erO9sgBd CqSnHdAZ5YQrM7LZ181Y1gd+hj5sbicKOmda6gsDZeZZzWtzSLAAB8FpKnpPSTKC rQI6n2W18Cnu8TEY+KfBeaP72TAO0PJz1bO+YywjcFfLEy7bYGED6quQrY/4164L llyU0HyaTESYYudnXFbz/URwdcNyRNcCLeGbzOsL+93WXKUuP8+zgRs86E5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712826650; x=1712913050; bh=tjsVx4nQhxZS45gfmhMJ/ocdUu92 HV7bOMCb/JVjw2E=; b=nzFwlfhuMioec0NjWoqU9RqxDYqKpDFTuEppBDl/TXED T4CLXbw7yH3rTFlomp3v8QLbNJnfNKGPsbOgNSYadYdnvKArCU9yFWJ5bA8yJPYr riqGCkY4RWmN+x0+D+XBTrHkXBj6ZEH3tQWnDEPXtTFrlU/fzlSkikFNfEAHhJOJ xAfN9IXry0LZV06gKVyRaLi7AJNs9i09QaxXHL/01nKRLMP7121OQXdc/HllQqHD WjmQlL6NrPHh0ni+QQTFQsCNWeM8AhOL5GCgbTxMfqddB7ofVUY8hLkimDAzrnMp XlvsvGOIN6lqsgY0BVN0OkL9/ZcNMvBFE0vAbdDlBw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehkedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepueektdevtdffveeljeetgfehheeigeekleduvdeffeeghefgledttdehjeelffet necuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepphhsse hpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Apr 2024 05:10:49 -0400 (EDT) Received: by localhost (OpenSMTPD) with ESMTPSA id 0ae94a03 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 11 Apr 2024 09:10:37 +0000 (UTC) Date: Thu, 11 Apr 2024 11:10:47 +0200 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Han-Wen Nienhuys , Josh Steadmon , Luca Milanesio , Eric Sunshine , Toon Claes , Justin Tobler Subject: [PATCH v3 09/13] ci: make Perforce binaries executable for all users Message-ID: References: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: The Perforce binaries are only made executable for the current user. On GitLab CI though we execute tests as a different user than "root", and thus these binaries may not be executable by that test user at all. This has gone unnoticed so far because those binaries are optional -- in case they don't exist we simply skip over tests requiring them. Fix the setup so that we set the executable bits for all users. Signed-off-by: Patrick Steinhardt --- ci/install-dependencies.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index e673797115..0b9bb686d8 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -47,7 +47,7 @@ ubuntu-*) mkdir --parents "$CUSTOM_PATH" wget --quiet --directory-prefix="$CUSTOM_PATH" \ "$P4WHENCE/bin.linux26x86_64/p4d" "$P4WHENCE/bin.linux26x86_64/p4" - chmod u+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" + chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" wget --quiet "$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" tar -xzf "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" \