| Message ID | patch-1.5-351c6a55a41-20230123T170551Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hook API: support stdin, convert post-rewrite | expand |
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > Remove code that's been unused since it was added in > c553c72eed6 (run-command: add an asynchronous parallel child > processor, 2015-12-15), the next use of "i" in this function is: > > for (i = 0; ... And it has been updated to a different type, i.e. for (size_t i = 0; ... so it doubly makes sense to kill that unused variable. Makes sense. > So we'll always clobber the "i" that's set here. Presumably the "i" > assignment is an artifact of WIP code that made it into our tree. > > A subsequent commit will need to adjust the type of the "i" variable > in the otherwise unrelated for-loop, which is why this is being > removed now. That, together with the earlier mention of the other i (which I think came from the same source---perhaps the original topic this was taken from had int->size_t change in it) are both stale. Please proofread what you send out before submitting. Thanks.
diff --git a/run-command.c b/run-command.c index 50cc011654e..b439c7974ca 100644 --- a/run-command.c +++ b/run-command.c @@ -1632,9 +1632,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp, const struct run_process_parallel_opts *opts, int output_timeout) { - int i; - - while ((i = poll(pp->pfd, opts->processes, output_timeout) < 0)) { + while (poll(pp->pfd, opts->processes, output_timeout) < 0) { if (errno == EINTR) continue; pp_cleanup(pp, opts);
Remove code that's been unused since it was added in c553c72eed6 (run-command: add an asynchronous parallel child processor, 2015-12-15), the next use of "i" in this function is: for (i = 0; ... So we'll always clobber the "i" that's set here. Presumably the "i" assignment is an artifact of WIP code that made it into our tree. A subsequent commit will need to adjust the type of the "i" variable in the otherwise unrelated for-loop, which is why this is being removed now. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- run-command.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)