diff mbox series

[2/2] bundle <cmd>: have usage_msg_opt() note the missing "<file>"

Message ID patch-2.2-00f74250fd0-20221227T183708Z-avarab@gmail.com (mailing list archive)
State Accepted
Commit 6d5e9e53aa46b97227a25c85400fd00b8237411a
Headers show
Series builtin/bundle.c: segfault fix style & error reporting follow-up | expand

Commit Message

Ævar Arnfjörð Bjarmason Dec. 27, 2022, 6:39 p.m. UTC
Improve the usage we emit on e.g. "git bundle create" to note why
we're showing the usage, it's because the "<file>" argument is
missing.

We know that'll be the case for all parse_options_cmd_bundle() users,
as they're passing the "char **bundle_file" parameter, which as the
context shows we're expected to populate.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/bundle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/builtin/bundle.c b/builtin/bundle.c
index 3d1ad220ff8..acceef62001 100644
--- a/builtin/bundle.c
+++ b/builtin/bundle.c
@@ -58,7 +58,7 @@  static int parse_options_cmd_bundle(int argc,
 	argc = parse_options(argc, argv, NULL, options, usagestr,
 			     PARSE_OPT_STOP_AT_NON_OPTION);
 	if (!argc)
-		usage_with_options(usagestr, options);
+		usage_msg_opt(_("need a <file> argument"), usagestr, options);
 	*bundle_file = prefix_filename(prefix, argv[0]);
 	return argc;
 }