[v5,01/15] cmake: don't invoke msgfmt with --statistics

Message ID	patch-v5-01.15-7d83ff44c61-20221202T110947Z-avarab@gmail.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <avarab@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Johannes Schindelin <Johannes.Schindelin@gmx.de>, Phillip Wood <phillip.wood123@gmail.com>, Victoria Dye <vdye@github.com>, Eric Sunshine <ericsunshine@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= <avarab@gmail.com> Subject: [PATCH v5 01/15] cmake: don't invoke msgfmt with --statistics Date: Fri, 2 Dec 2022 12:28:22 +0100 Message-Id: <patch-v5-01.15-7d83ff44c61-20221202T110947Z-avarab@gmail.com> In-Reply-To: <cover-v5-00.15-00000000000-20221202T110947Z-avarab@gmail.com> References: <cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com> <cover-v5-00.15-00000000000-20221202T110947Z-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	cmake: document, fix on nix, add CI \| expand [v5,00/15] cmake: document, fix on nix, add CI [v5,01/15] cmake: don't invoke msgfmt with --statistics [v5,02/15] cmake: use "-S" and "-B" to specify source and build directories [v5,03/15] cmake: update instructions for portable CMakeLists.txt [v5,04/15] cmake: don't copy chainlint.pl to build directory [v5,05/15] cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4 [v5,06/15] cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable [v5,07/15] cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh [v5,08/15] Makefile + test-lib.sh: don't prefer cmake-built to make-built git [v5,09/15] test-lib.sh: support a "GIT_TEST_BUILD_DIR" [v5,10/15] cmake: optionally be able to run tests before "ctest" [v5,11/15] cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults [v5,12/15] cmake: increase test timeout on Windows only [v5,13/15] cmake: only look for "sh" in "C:/Program Files" on Windows [v5,14/15] cmake: copy over git-p4.py for t983[56] perforce test [v5,15/15] CI: add a "linux-cmake-test" to run cmake & ctest on linux

Message ID

patch-v5-01.15-7d83ff44c61-20221202T110947Z-avarab@gmail.com (mailing list archive)

State

Superseded

Headers

From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?=  <avarab@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
 Phillip Wood <phillip.wood123@gmail.com>, Victoria Dye <vdye@github.com>,
 Eric Sunshine <ericsunshine@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?=
	=?utf-8?b?amFybWFzb24=?=  <avarab@gmail.com>
Subject: [PATCH v5 01/15] cmake: don't invoke msgfmt with --statistics
Date: Fri,  2 Dec 2022 12:28:22 +0100
Message-Id: <patch-v5-01.15-7d83ff44c61-20221202T110947Z-avarab@gmail.com>
In-Reply-To: <cover-v5-00.15-00000000000-20221202T110947Z-avarab@gmail.com>
References: <cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com>
 <cover-v5-00.15-00000000000-20221202T110947Z-avarab@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

cmake: document, fix on *nix, add CI | expand

Commit Message

Ævar Arnfjörð Bjarmason Dec. 2, 2022, 11:28 a.m. UTC

In 2f12b31b746 (Makefile: don't invoke msgfmt with --statistics,
2021-12-17) I made the same change to our Makefile, let's follow-up
and do the same here.

For "cmake" this is particularly nice with "-G Ninja", as before we'd
emit ~40 lines of overflowed progress bar output, but now it's only
the one line of "ninja"'s progress bar.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 contrib/buildsystems/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
index 2f6e0197ffa..8f8b6f375f7 100644
--- a/contrib/buildsystems/CMakeLists.txt
+++ b/contrib/buildsystems/CMakeLists.txt
@@ -897,7 +897,7 @@  if(MSGFMT_EXE)
 	foreach(po ${po_files})
 		file(MAKE_DIRECTORY ${CMAKE_BINARY_DIR}/po/build/locale/${po}/LC_MESSAGES)
 		add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/po/build/locale/${po}/LC_MESSAGES/git.mo
-				COMMAND ${MSGFMT_EXE} --check --statistics -o ${CMAKE_BINARY_DIR}/po/build/locale/${po}/LC_MESSAGES/git.mo ${CMAKE_SOURCE_DIR}/po/${po}.po)
+				COMMAND ${MSGFMT_EXE} --check -o ${CMAKE_BINARY_DIR}/po/build/locale/${po}/LC_MESSAGES/git.mo ${CMAKE_SOURCE_DIR}/po/${po}.po)
 		list(APPEND po_gen ${CMAKE_BINARY_DIR}/po/build/locale/${po}/LC_MESSAGES/git.mo)
 	endforeach()
 	add_custom_target(po-gen ALL DEPENDS ${po_gen})

[v5,01/15] cmake: don't invoke msgfmt with --statistics

Commit Message

Patch