check-non-portable-shell: detect obsolescent egrep/fgrep

Commit Message

Eric Sunshine Sept. 22, 2022, 12:18 a.m. UTC

From: Eric Sunshine <[e-mail]>

GNU grep deprecated `egrep` and `fgrep` with release 2.5.3 in 2007.
As of release 3.8 in 2022, those commands warn[1] that they are
obsolescent. Now that all the Git test scripts have been scrubbed of
uses of `egrep` and `fgrep`, make `check-non-portable-shell` complain
about them to prevent new instances from creeping back into the project.

[1]: https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html

Signed-off-by: Eric Sunshine <[e-mail]>
---
    check-non-portable-shell: detect obsolescent egrep/fgrep
    
    This is atop 'dd/retire-efgrep'.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1338%2Fsunshineco%2Fefgrep-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1338/sunshineco/efgrep-v1
Pull-Request: https://github.com/git/git/pull/1338

 t/check-non-portable-shell.pl | 1 +
 1 file changed, 1 insertion(+)


base-commit: 1b3d6e17fe83eb6f79ffbac2f2c61bbf1eaef5f8

Patch

diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index fd3303552be..dd8107cd7da 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -45,6 +45,7 @@  while (<>) {
 	/\bhead\s+-c\b/ and err 'head -c is not portable (use test_copy_bytes BYTES <file >out)';
 	/(?:\$\(seq|^\s*seq\b)/ and err 'seq is not portable (use test_seq)';
 	/\bgrep\b.*--file\b/ and err 'grep --file FILE is not portable (use grep -f FILE)';
+	/\b[ef]grep\b/ and err 'egrep/fgrep obsolescent (use grep -E/-F)';
 	/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)';
 	/^\s*([A-Z0-9_]+=(\w*|(["']).*?\3)\s+)+(\w+)/ and exists($func{$4}) and
 		err '"FOO=bar shell_func" assignment extends beyond "shell_func"';