| Message ID | pull.1608.git.1698958277454.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3ca86adc2db4cd184f38596d4ba44c6870b2a7e4 |
| Headers | show |
| Series | strvec: drop unnecessary include of hex.h | expand |
"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Linus Arver <linusa@google.com> > > In 41771fa435 (cache.h: remove dependence on hex.h; make other files > include it explicitly, 2023-02-24) we added this as part of a larger > mechanical refactor. But strvec doesn't actually depend on hex.h, so > remove it. > > Signed-off-by: Linus Arver <linusa@google.com> > --- > strvec: drop unnecessary include of hex.h > > In 41771fa435 (cache.h: remove dependence on hex.h; make other files > include it explicitly, 2023-02-24) we added this as part of a larger > mechanical refactor. But strvec doesn't actually depend on hex.h, so > remove it. This change somehow looks familiar. > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/1608 > > strvec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/strvec.c b/strvec.c > index 89dc9e7e753..178f4f37480 100644 > --- a/strvec.c > +++ b/strvec.c > @@ -1,6 +1,5 @@ > #include "git-compat-util.h" > #include "strvec.h" > -#include "hex.h" > #include "strbuf.h" Makes sense. Will queue. Thanks.
diff --git a/strvec.c b/strvec.c index 89dc9e7e753..178f4f37480 100644 --- a/strvec.c +++ b/strvec.c @@ -1,6 +1,5 @@ #include "git-compat-util.h" #include "strvec.h" -#include "hex.h" #include "strbuf.h" const char *empty_strvec[] = { NULL };