From patchwork Fri Dec 16 01:47:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Junio C Hamano X-Patchwork-Id: 13074727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E9AC4332F for ; Fri, 16 Dec 2022 01:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbiLPBrZ (ORCPT ); Thu, 15 Dec 2022 20:47:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbiLPBrW (ORCPT ); Thu, 15 Dec 2022 20:47:22 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF7602BB01 for ; Thu, 15 Dec 2022 17:47:20 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id d82so799993pfd.11 for ; Thu, 15 Dec 2022 17:47:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=vTJH8jxW+qdbO+0po4BigY2q3TK8TME8iG7XZO+Phis=; b=G0K8ktN97n/OldKcXcJg5aOOIkPngEMrx090AZidy9IudSnzdA/IZtgyHc/W2kjhgT PKRvLSU+NH9jEcrvwAzTBrw3CWacwT5KClF2NJUkg8jMMnxwh6xO6CvgG4zeK5bDRAql 4peXdBbFNqKlUNlFyvjbkhmt0Q05xDNeOLh+Gands+IYs4hqaXdlprKD8TQdmhVbOOFK OVUjUNdZr5T9IwKWy/DwUkFfYw51xZtKiS0A5irPztD5u9F0jDd2qTaSyYRXYLVbwWL9 bRxKcWrmPZ32piL0swwpJBVjx8azaB4gDUHYDk3ODI3yYkO16SFK2ePbIla1JVTorQ5d U8Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vTJH8jxW+qdbO+0po4BigY2q3TK8TME8iG7XZO+Phis=; b=QeHlokFfWwM+EgSyAHwM7g04NtSERGXuvgRsMgyTQPTUvHJwAd9AHeyjlAwWRliEsp fBYyc6R/5S+BetayHENrOUiQ4pnqycHEavl0o4kmjdpdErYYT+ptaMFQQ/Fj7zwu8d9b rS9/psKi3wqtymud0IBh/E5ts4szo0VYCPx0quew2b/bg8n22Zsu9vQvUQx/TCYp7k1L uDclYrYonjGpARRZ1TTPgk0hC2Dy8QkXK/T4k7Wj8T6LCvxWgYxxaTVlI2qKnNivk9u0 c3vHYQiNTz1gmVwznUQQXVWNN9lX7oUDjfKwvd835FlWRxw/ygZ6Kqz1ETArPPi2NjKP 7YCw== X-Gm-Message-State: ANoB5pkKOSyz3fu6MG8N1g10SVjS2Irr0dUgIrObs9Kp33lQZz/SVak8 E9/J++IXzTZ3snd9BmF9JF+c0V2xujwWiQ== X-Google-Smtp-Source: AA0mqf4miGWGBsTd4uI1pFDvkP53ISmVgVui8fT8omIEtoNwTbO0+kwoijlxS54hMRUVR+X4VpMVeA== X-Received: by 2002:a62:1a94:0:b0:56b:dae1:e946 with SMTP id a142-20020a621a94000000b0056bdae1e946mr28886574pfa.28.1671155239956; Thu, 15 Dec 2022 17:47:19 -0800 (PST) Received: from localhost (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id w7-20020a626207000000b00562677968aesm251550pfb.72.2022.12.15.17.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 17:47:19 -0800 (PST) Sender: Junio C Hamano From: Junio C Hamano To: git@vger.kernel.org Subject: [PATCH] e-mail workflow: Message-ID is spelled with ID in both capital letters Date: Fri, 16 Dec 2022 10:47:19 +0900 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org We used to write "Message-Id:" and "Message-ID:" pretty much interchangeably, and the header name is defined to be case insensitive by the RFCs, but the canonical form "Message-ID:" is used throughout the RFC documents, so let's imitate it ourselves. Signed-off-by: Junio C Hamano Reviewed-by: Elijah Newren Reviewed-by: mirth.hickford@gmail.com --- Documentation/MyFirstContribution.txt | 14 +++---- Documentation/git-format-patch.txt | 4 +- Documentation/git-send-email.txt | 2 +- git-send-email.perl | 4 +- log-tree.c | 2 +- mailinfo.c | 4 +- t/t4014-format-patch.sh | 56 +++++++++++++-------------- t/t4150-am.sh | 8 ++-- t/t4258/mbox | 2 +- t/t5100/msg0002 | 2 +- t/t5100/msg0003 | 2 +- t/t5100/msg0012--message-id | 2 +- t/t5100/quoted-cr.mbox | 4 +- t/t5100/sample.mbox | 6 +-- t/t9001-send-email.sh | 38 +++++++++--------- 15 files changed, 75 insertions(+), 75 deletions(-) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index ccfd0cb5f3..2f8b7d597f 100644 --- a/Documentation/MyFirstContribution.txt +++ b/Documentation/MyFirstContribution.txt @@ -1171,21 +1171,21 @@ between your last version and now, if it's something significant. You do not need the exact same body in your second cover letter; focus on explaining to reviewers the changes you've made that may not be as visible. -You will also need to go and find the Message-Id of your previous cover letter. +You will also need to go and find the Message-ID of your previous cover letter. You can either note it when you send the first series, from the output of `git send-email`, or you can look it up on the https://lore.kernel.org/git[mailing list]. Find your cover letter in the -archives, click on it, then click "permalink" or "raw" to reveal the Message-Id +archives, click on it, then click "permalink" or "raw" to reveal the Message-ID header. It should match: ---- -Message-Id: +Message-ID: ---- -Your Message-Id is ``. This example will be used -below as well; make sure to replace it with the correct Message-Id for your -**previous cover letter** - that is, if you're sending v2, use the Message-Id -from v1; if you're sending v3, use the Message-Id from v2. +Your Message-ID is ``. This example will be used +below as well; make sure to replace it with the correct Message-ID for your +**previous cover letter** - that is, if you're sending v2, use the Message-ID +from v1; if you're sending v3, use the Message-ID from v2. While you're looking at the email, you should also note who is CC'd, as it's common practice in the mailing list to keep all CCs on a thread. You can add diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt index dfcc7da4c2..508f3ae2c0 100644 --- a/Documentation/git-format-patch.txt +++ b/Documentation/git-format-patch.txt @@ -99,7 +99,7 @@ To omit patch numbers from the subject, use `-N`. If given `--thread`, `git-format-patch` will generate `In-Reply-To` and `References` headers to make the second and subsequent patch mails appear -as replies to the first mail; this also generates a `Message-Id` header to +as replies to the first mail; this also generates a `Message-ID` header to reference. OPTIONS @@ -163,7 +163,7 @@ include::diff-options.txt[] --no-thread:: Controls addition of `In-Reply-To` and `References` headers to make the second and subsequent mails appear as replies to the - first. Also controls generation of the `Message-Id` header to + first. Also controls generation of the `Message-ID` header to reference. + The optional